-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wallet: enable importing names and "watch" for auction activity without bidding #408
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pinheadmz left some comments.
@boymanjor thanks bud, nits are picked! |
This enables a user to import a name into their wallet in a similar way to importing an address or public key. A rescan is still required to recover any auction activity and in particular the OPEN for a name MUST be rescanned or the wallet will not record a nameState or track any bids. The WalletDB global name->wid map is used as a "watch" marker to determine if a name's OPEN should be added to the txdb.
Codecov Report
@@ Coverage Diff @@
## master #408 +/- ##
==========================================
+ Coverage 61.79% 61.89% +0.09%
==========================================
Files 129 129
Lines 34830 34862 +32
Branches 5918 5923 +5
==========================================
+ Hits 21524 21577 +53
+ Misses 13306 13285 -21
Continue to review full report at Codecov.
|
This enables a user to import a name into their wallet in a similar way to importing an address or public key. A rescan is still required to recover any auction activity and in particular the OPEN for a name MUST be rescanned or the wallet will not record a
nameState
or track any bids.The WalletDB global
name->wid
map is used as a "watch" marker to determine if a name's OPEN should be added to the txdb.The new rpc command takes a rescan height parameter:
Wallet applications should check the state of a name and use a name's
height - 1
as the rescan height. Assuming the auction is still in bidding phase, this will initiate a wallet rescan of maximum 5 days.See kyokan/bob-wallet#108