Wallet: enable importing names and "watch" for auction activity without bidding #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boymanjor
reviewed
Mar 31, 2020
|
@boymanjor thanks bud, nits are picked! |
This enables a user to import a name into their wallet in a similar way to importing an address or public key. A rescan is still required to recover any auction activity and in particular the OPEN for a name MUST be rescanned or the wallet will not record a nameState or track any bids. The WalletDB global name->wid map is used as a "watch" marker to determine if a name's OPEN should be added to the txdb.
Codecov Report
@@ Coverage Diff @@
## master #408 +/- ##
==========================================
+ Coverage 61.79% 61.89% +0.09%
==========================================
Files 129 129
Lines 34830 34862 +32
Branches 5918 5923 +5
==========================================
+ Hits 21524 21577 +53
+ Misses 13306 13285 -21
Continue to review full report at Codecov.
|
boymanjor
approved these changes
Apr 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables a user to import a name into their wallet in a similar way to importing an address or public key. A rescan is still required to recover any auction activity and in particular the OPEN for a name MUST be rescanned or the wallet will not record a
nameStateor track any bids.The WalletDB global
name->widmap is used as a "watch" marker to determine if a name's OPEN should be added to the txdb.The new rpc command takes a rescan height parameter:
Wallet applications should check the state of a name and use a name's
height - 1as the rescan height. Assuming the auction is still in bidding phase, this will initiate a wallet rescan of maximum 5 days.See kyokan/bob-wallet#108