Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node: accept --no-dns configuration option to disable NS and RS #554

Merged
merged 1 commit into from Mar 23, 2021

Conversation

pinheadmz
Copy link
Member

@pinheadmz pinheadmz commented Feb 5, 2021

Closes #528

Summary (also included in CHANGELOG):

  • FullNode and SPVNode accept configuration parameter --no-dns (or no-dns: true in
    hsd.conf) which launches the node without either DNS server (the root authoritative
    server and the recursive resolver). This avoids some port collisions with other HNS resolvers
    like hnsd running locally, and generally separates and reduces security concerns around
    running unneeded servers when a node is just used for transactions and blocks.
    --no-rs is also accepted to disable the recursive DNS resolver (but keep the root server).

The default is false (meaning by default, hsd runs with the DNS servers).

@coveralls
Copy link

coveralls commented Feb 5, 2021

Pull Request Test Coverage Report for Build 680468365

  • 24 of 26 (92.31%) changed or added relevant lines in 2 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.1%) to 59.708%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/node/fullnode.js 12 13 92.31%
lib/node/spvnode.js 12 13 92.31%
Files with Coverage Reduction New Missed Lines %
lib/protocol/consensus.js 1 82.79%
lib/net/pool.js 2 30.27%
Totals Coverage Status
Change from base Build 676632891: 0.1%
Covered Lines: 19672
Relevant Lines: 30684

💛 - Coveralls

@pinheadmz pinheadmz added this to the v2.4.0 milestone Feb 5, 2021
@pinheadmz
Copy link
Member Author

After discussion with @buffrr I think a better choice is keeping --no-dns but also adding --no-rs because in some configurations it may desirable to just run hsd as a root name server and use something externally (like BIND) for the recursive.

Copy link
Contributor

@nodech nodech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lib/node/fullnode.js Outdated Show resolved Hide resolved
@pinheadmz pinheadmz merged commit 2d1cbe9 into handshake-org:master Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Full and SPV nodes should have a --no-dns option
3 participants