Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dns: fix root zone dnssec #566

Merged
merged 4 commits into from
Mar 2, 2021
Merged

Conversation

pinheadmz
Copy link
Member

@pinheadmz pinheadmz commented Feb 25, 2021

Closes #565

Based on james-stevens@18cdabc

TODO:

Changes:

  • Root always signs DS, never signs NS, and only signs TXT if NS is not present
  • Root always sets aa (authority) bit for DS, never for NS, and for TXT only if NS is not present
  • Root doesn't answer a query for TXT if NS is present (sends referral instead)
  • Root sets authority bit for NXDOMAIN

Co-authored-by: James Stevens <github@jrcs.net>
@coveralls
Copy link

coveralls commented Feb 25, 2021

Pull Request Test Coverage Report for Build 600554084

  • 7 of 9 (77.78%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-8.2%) to 59.379%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/dns/server.js 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
lib/dns/resource.js 1 80.04%
lib/protocol/consensus.js 1 82.79%
Totals Coverage Status
Change from base Build 541449016: -8.2%
Covered Lines: 19511
Relevant Lines: 30584

💛 - Coveralls

Copy link
Contributor

@tuxcanfly tuxcanfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. I checked against the linked issue and rationale seems to be to avoid conflict by preferring NS over TXT from the root zone. It maybe a good idea to update the PR with the conclusion from the linked issue and rationale for making this change.

lib/dns/resource.js Show resolved Hide resolved
@pinheadmz pinheadmz merged commit f2702f8 into handshake-org:master Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should HNS root nameserver serve TXT records?
3 participants