Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use synth address for root server NS #630

Merged
merged 4 commits into from
Sep 29, 2021

Conversation

pinheadmz
Copy link
Member

@pinheadmz pinheadmz commented Aug 31, 2021

Closes #400

  • TODO: Needs tests

Also imports a fix from hnsd PR handshake-org/hnsd#67 which returns empty SOA if _synth is queried by itself (encourages the recursive resolver to ask again with the full synth address)

Third commit adds newlines \n\n before DNS messages in the log. These messages are only printed at --log-level=spam anyway and improve readability a whole heckuva lot:

Screen Shot 2021-08-31 at 10 01 25 AM

@coveralls
Copy link

coveralls commented Sep 1, 2021

Pull Request Test Coverage Report for Build 1283354237

  • 15 of 19 (78.95%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.01%) to 62.207%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/dns/server.js 15 19 78.95%
Files with Coverage Reduction New Missed Lines %
lib/protocol/consensus.js 1 82.79%
lib/utils/binary.js 1 56.9%
Totals Coverage Status
Change from base Build 1262200388: -0.01%
Covered Lines: 21166
Relevant Lines: 31797

💛 - Coveralls

Copy link
Contributor

@buffrr buffrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm this PR makes dig +trace usable if hsd is configured as a system resolver. Using a _synth address for the root NS avoids adding an A record to the zone apex 👍

We may want to clean up DNSSEC for _synth negative answers eventually but don't think it's a high priority for now since its mainly for correctness. LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DNS Resolver: "Couldn't get address for '.': not found" with +trace
3 participants