Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renderer: 'html' and minSpareRows is inserting 'null' into new cells. #2816

Closed
djseng opened this issue Sep 16, 2015 · 2 comments
Closed

renderer: 'html' and minSpareRows is inserting 'null' into new cells. #2816

djseng opened this issue Sep 16, 2015 · 2 comments

Comments

@djseng
Copy link

djseng commented Sep 16, 2015

Here is a fiddle that reproduces the issue. http://jsfiddle.net/ao26oekz/14/

@AMBudnik
Copy link
Contributor

Thank you @djseng confirmed
null values are gone partly where we type something into the cell like <a href="#">a</a>
zrzut ekranu 2015-09-16 o 17 03 57

@djseng
Copy link
Author

djseng commented Sep 16, 2015

I'm using the following renderer temporarily:

function cleanHtmlRenderer(instance, td, row, col, prop, value, cellProperties){
    Handsontable.renderers.HtmlRenderer.apply(this, arguments);
    if (td.innerHTML === 'null') {
        td.innerHTML = '';
    }
}

@budnix budnix added this to the 0.19.0 milestone Sep 24, 2015
vo-va added a commit to vo-va/handsontable that referenced this issue Oct 31, 2015
@krzysztofspilka krzysztofspilka modified the milestones: 0.20.1, 0.20.2 Nov 16, 2015
@krzysztofspilka krzysztofspilka modified the milestones: 0.20.2, 0.20.3 Dec 4, 2015
@krzysztofspilka krzysztofspilka modified the milestones: 0.20.3, 0.20.4 Jan 8, 2016
@jansiegel jansiegel self-assigned this Jan 14, 2016
@jansiegel jansiegel assigned budnix and unassigned jansiegel Jan 14, 2016
jansiegel added a commit that referenced this issue Jan 14, 2016
@jansiegel jansiegel assigned jansiegel and unassigned budnix Jan 14, 2016
Jazzo added a commit to Jazzo/handsontable that referenced this issue Jan 23, 2016
* commit '461a1eefb66b3938589c76de0d10d9b93e6dba8a': (190 commits)
  0.21.0
  Update documentation
  Update documentation
  Fixed throwing error when no first argument was passed. handsontable#933
  Fix wrong variable declaration. handsontable#3014
  Fix invalid sorting on a horizontally scrolled table. handsontable#3014
  Remove the 'private' annotation from some helper classes to prevent 404s in the documentation.
  Add missing property types
  Add mising property type
  Add the HOT-Pro properties to the core in order to make them work in ngHandsontable.
  Fixed context menu tests
  Added missing tests and fixed submenu position when page has window scrollbars. handsontable#3124
  Rename physicalRow and physicalCol to visualRow and visualCol in the cell properties. handsontable#3132
  Pass the visual row index to the afterValidate, beforeValidate and poastAfterValidate hooks (instead of the 'base' row index) handsontable#3132
  Added delay for open submenu action. handsontable#3126
  Fix problems with pasting data near the bottom edge on the Pro version.
  Fixed submenu position when it doesn't fit to the browser's viewport. handsontable#3124
  Update autoRowSize and autoColumnSize docs.
  Another approach to handsontable#2816 + tests
  Prevent inserting 'null' inside empty rows when using the HTML renderer. handsontable#2816
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants