Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop down not visible for the last row #3210

Closed
jeanmarc78 opened this issue Feb 10, 2016 · 14 comments
Closed

drop down not visible for the last row #3210

jeanmarc78 opened this issue Feb 10, 2016 · 14 comments

Comments

@jeanmarc78
Copy link

hello,
i have an handsontable with drop down list,
if i go to the last row , the drop down list is truncated.
regards
jm

http://jsfiddle.net/jeanmarc/81f0x1u6/
dropdowntruncated

@AMBudnik
Copy link
Contributor

Confirmed. Thanks for sharing @jeanmarc78

@krzysztofspilka
Copy link
Member

@AMBudnik That's going to be a HUGE refactor of all editors. We'll start it next week and according to our roadmap it should be finished till the end of March. (edited on April 11)

@jansiegel jansiegel self-assigned this Mar 21, 2016
@AMBudnik
Copy link
Contributor

May have an impact on #2380

@krzysztofspilka
Copy link
Member

From now on the dropdown will open to the top if there're too little space below it. This is just a workaround before we fully refactor the editors' code.

@Vinitha07ec
Copy link

But if the dropdown contains more values then we need to scroll the entire handsontable container to view the full options.Could you please work on this

@mariusk
Copy link

mariusk commented Apr 28, 2016

I'll just add another opinion on this. Using multiple handsontable instances on one page with autocomplete just isn't working. And it doesn't seem like something that is easily fixed by twiddling around z-index values in css files either. I haven't taken the time to figure out why, but I'm guessing there are hardcoded z-index values being set on dynamic elements like autocomplete tables. It's also painful on a more generic level, where table headers has a tendency to appear on top of other stuff. While I believe the latter may be solvable with documentation, I doubt the former can.

@AMBudnik
Copy link
Contributor

@mariusk thanks for sharing. I created a new issue of your comment at #3443

@hbeita
Copy link

hbeita commented May 25, 2016

Hello, I still have this issue due the fact that spaceBelow can be equal to spaceAbove on that scenario, the dropdown options are still unable to read, in this case handsontable should flip the dropdown up so the evaluation here should be if (flipNeeded && spaceAbove >= spaceBelow) instead of (flipNeeded && spaceAbove > spaceBelow), here is the commit line for the above suggestion change: autocomplete flip upwards commit

e.g:

  • with the current release if (flipNeeded && spaceAbove > spaceBelow)
    image
  • implementing if (flipNeeded && spaceAbove >= spaceBelow)
    image

@AMBudnik
Copy link
Contributor

@hgarciab could you share a demo where we will be able to replicate the issue?

ps. while I was testing this solution I came across this situation: http://jsbin.com/rojaroluqi/1/edit?js,output

I think that the dropdown menu should open above the cell not create an extra space on the page, but waiting for your opinion.

@hbeita
Copy link

hbeita commented May 30, 2016

Sure @AMBudnik, here is the demo, hope this helps: https://jsfiddle.net/BeitaHere/6hf52e6x/7/, and yes I think would be better not use space that doesn't exists on the screen.

@AMBudnik
Copy link
Contributor

thanks for sharing @hgarciab
I'm reopening this issue. We have to test it more.

@AMBudnik
Copy link
Contributor

after fixing this issue we should also check this one: #3443

@jaredbaszler
Copy link

I just ran into this issue today as we recently implemented a horizontal scroll bar on our HOT. We only start with a single row and the main purpose is to let users add the x-amount of rows they need. Which means the row they are working on is always at the bottom. So this issue is compounded by that fact. Please fix soon:

image

@AMBudnik
Copy link
Contributor

Current topic for this issue: #3435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants