Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESlint rules update #4366

Closed
budnix opened this issue Jul 4, 2017 · 2 comments
Closed

ESlint rules update #4366

budnix opened this issue Jul 4, 2017 · 2 comments
Assignees
@budnix
Labels
bug Core: Handsontable Plugin Guess: A few hours Status: Released
Milestone
0.33.0

Comments

@budnix
Copy link
Member

budnix commented Jul 4, 2017

Description

To prevent this bug I suggest adding a rule to the ESLint. This rule will be responsible for checking if any of commits does not contain code which directly touches a Handsontable variable.

Steps to reproduce

  1. Build Handsontable example using browserify (or webpack etc.).
  2. Open a dropdown editor.
  3. There will be an error about trying to access to Handsontable variable which does not exist.

Your environment

  • Handsontable version: 0.32.0
@budnix budnix self-assigned this Jul 4, 2017
budnix added a commit that referenced this issue Jul 4, 2017
@budnix
Updated eslint to v4 and added new rules. #4366
0377d90
@budnix budnix assigned wszymanski and unassigned budnix Jul 4, 2017
@wszymanski wszymanski assigned budnix and unassigned wszymanski Jul 5, 2017
@budnix budnix added this to the 0.33.0 milestone Jul 5, 2017
@AMBudnik
Copy link
Contributor

Thanks for adding @budnix

@budnix
Copy link
Member Author

budnix commented Jul 12, 2017

No problem, it was a pleasure 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@budnix budnix

Labels
bug Core: Handsontable Plugin Guess: A few hours Status: Released
Projects
None yet
Milestone
0.33.0
Development

No branches or pull requests
4 participants
@wszymanski @budnix @krzysztofspilka @AMBudnik