Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unwanted first character using IME API #4662

Closed
budnix opened this issue Dec 8, 2017 · 9 comments
Closed

Unwanted first character using IME API #4662

budnix opened this issue Dec 8, 2017 · 9 comments

Comments

@budnix
Copy link
Member

budnix commented Dec 8, 2017

Description

The unwanted first character appears in the editor when IME API is used.

Steps to reproduce

  1. Select Chinese (pinyin) keyboard layout;
  2. Go to https://handsontable.com/features delete text Task 33 (cell A1) and switch cell into editing mode (press enter);
  3. Press esc to exit from editing mode;
  4. Press letters ceshi

In result, the editor should contain only Chinese symbols. Instead, the first character is visible as English character.

Your environment

  • Handsontable version: 0.35.0
  • Browser Name and version: *
  • Operating System: macOS

33757738-65614a5c-dc36-11e7-98fd-53170f55fb9a

@budnix
Copy link
Member Author

budnix commented Dec 13, 2017

This #4661 issue is the same as this but with different behavior on Safari.

@krzysztofspilka
Copy link
Member

budnix added a commit that referenced this issue Jan 8, 2018
budnix added a commit that referenced this issue Jan 8, 2018
preparation (due to the cursor overlapping on IE). #4662
@budnix
Copy link
Member Author

budnix commented Jan 8, 2018

The issue is rescheduled to February.

Tasks to be finished/fixed:

  • The IME editor shouldn't appear on checkbox editor and on cells marked as readOnly;
  • Add some tests to cover that editing is working for Asia users;
  • On FF the bug with unwanted first character still exists but only limited to dropdown and autocomplete editors;
  • Check if focus which is stolen by copyPaste plugin on selection end breaks the editing;
  • Test on different scenarios and on different environments (Windows, macOS, Linux);
  • Due to using z-index CSS property to hide/show editable element check if this approach doesn't break any older features (especially on IE and Edge - cursor overlapping bug).

@krzysztofspilka krzysztofspilka modified the milestones: next release, Backlog Jan 9, 2018
@ruzia
Copy link

ruzia commented Feb 17, 2018

any new update?
I'm waiting for fix it.

@AMBudnik
Copy link
Contributor

Hi @ruzia

there are still a few bugs that we need to finish before we will be able to get back to this project. I do not know if we will be able to do in in February (as predicted before) but we will do our best to try.

@wojciechczerniak wojciechczerniak removed this from the Backlog milestone Mar 22, 2018
budnix added a commit that referenced this issue Apr 20, 2018
@budnix budnix added this to the June 2018 milestone May 14, 2018
budnix added a commit that referenced this issue May 16, 2018
Fix unwanted first character on FF. Enabled the Copy/Paste
functionality, now IME works with copying, pasting and cutting.

Issue: #4662
budnix added a commit that referenced this issue May 17, 2018
@budnix budnix mentioned this issue May 17, 2018
6 tasks
budnix added a commit that referenced this issue May 30, 2018
budnix added a commit that referenced this issue Jun 4, 2018
budnix added a commit that referenced this issue Jun 4, 2018
* Fixed eslint error and added hiding an editable element on every editor
preparation;
* Add missing tests and remove commented code;
* Add more tests which check focus state after cell selection;
* Update TS definition file.

Issue: #4662
@budnix
Copy link
Member Author

budnix commented Jun 4, 2018

The IME was merged into develop branch. The editor is not compatible with fragmentSelection set to true. As a side effect, the IME tooltip appears when checkbox and select editor is set and when editor: false is set or cells are readOnly.

@budnix
Copy link
Member Author

budnix commented Jun 8, 2018

Additionally, there is some visual bug which occurs only on Edge browser. When we try to compose the word the first character is not visible in the input element but psychically it is there so it does not disturb later composition. After inputting the second character and so on, the whole text becomes visible. This will be fixed as a separate issue.

@AMBudnik
Copy link
Contributor

Hi @ruzia

please update to 4.0.0. The issue has been solved in this version.

@ruzia
Copy link

ruzia commented Jun 15, 2018

@budnix

thanks for reply!
I'll check 4.0.0 later. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants