-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
problem using other language #839
Comments
Well - this will be really hard to fix, because we don't know how to write in Korean. But we will be grateful if you can write a pull request for this (with a proper tests). |
If you use english, install korean or japanese (whatever 2byte language). At your home page (http://handsontable.com/index.html), you will see "aaa" -> "aㅁㅁ" ( in this case user want to write "ㅁㅁㅁ") Thank you. |
@Hokwang, could you pleas test if my latest fix solves the problem with korean characters? |
@psmolenski Sorry for late. The link has a problem, please check your link |
My fix has been merged into one of the recent version of Handsontable. Please use the latest version (0.9.16) and let me know if the problem still occurs. |
@psmolenski yes, still not fixed. |
@psmolenski seems not fixed in 0.9.17 |
@psmolenski still not fixed, 0.9.18 |
What about 0.10.x-beta? |
@psmolenski Did you test? I tested using 0.10.0-beta1. problem is still not fixed. Please install other language in your OS and test it. |
Which OS are you using @Hokwang ? |
@psmolenski I am using Windows 7. |
@psmolenski the problem is happened from version 0.7.5,seems still not fixed in the nearest version |
Chinese has the same issue. Chinese IDEs take multiple keys as input and outputs Chinese words in return, ex: jitui -> 雞腿. But when I write jitui, the j is consumed by handsontable and the IDE only gets itui. Without the j, the IDE translates itui to some random shit that I totally did not want to write. |
I also have the same problem in v0.10.3 (OS : Windows 7 sp1) |
@psmolenski I found this issue may be cause by this function.
}; |
Using 0.10.0-beta4, |
I made a simple modification, and it works at least with Japanese characters. /**
* Listen to document body keyboard input
*/
this.listen = function () {
Handsontable.activeGuid = instance.guid;
if (document.activeElement && document.activeElement !== document.body) {
//document.activeElement.blur();
}
else if (!document.activeElement) { //IE
//document.body.focus();
}
}; I commented those two lines. |
christchan's modification works well on Chrome, but not work on IE11 and Firefox34 |
I find a solution to fix the bug. version:0.12.2 line:3935 line:1199 comment |
@christchan this solve the IME problem ,but copy and paste function won't work well,it's weird |
Is there any follow-up on this issue? Edit: (Jun 3, 2015) Not so sure about Windows yet. Edit: (June 26, 2015) Edit: (July 22, 2015) |
It seems not fixed in 0.16.0. I think the following problems can be solved.
In order to avoid the bug, i changed the code below. handsontable.full.js line 6509 function init() {
instance.addHook('afterDocumentKeyDown', onKeyDown);
//eventManager.addEventListener(document.documentElement, 'keydown', function(event) {
eventManager.addEventListener(document.documentElement, 'keyup', function(event) { //keydown -> keyup
instance.runHooks('afterDocumentKeyDown', event);
}); line 6902 AutocompleteEditor.prototype.open = function() {
...
//this.focus(); //comment line 6967 AutocompleteEditor.prototype.updateChoicesList= function() {
...
// this.instance.listen(); //comment
// this.TEXTAREA.focus(); //comment |
I am really happy to have this old issue solved! Can I count on your feedback regarding testing the fix @awsp @teegh @zhouxiaoping @ruzia @minipai please also try the original fix @ChouGary @farthinker @kazuma1989 @gwajanara thank you for your feedback |
thank your hard work ,test with 0.35.0 here is my steps to reproduce issue here is video for reference |
@AMBudnik For Chinese IME (Cangjie), it only works on Chrome 62/63 but does not work on Safari 11. |
@ChouGary Can you tell me the English letter formula for the two of the words |
@AMBudnik |
Hi guys! I have one request for you. Yesterday we have added Internationalization and it would be great if you could share us some feedback. I'd be more than happy to see transactions for Chinese, Korean and Japanese. |
problem using other language: handsontable/handsontable#839
problem using other language: handsontable/handsontable#839
Hi guys, I tried ver. 0.35.0 to solve this issue and it seems working well. But unfortunately, I found that this issue reproduced with My environment is
This is just a report, and I have not found the cause of this problem, sorry. |
Hi @tacnoma thank you for reporting., Can I ask you to create a new issue for this bug? It will be much easier to attach new commits to it. |
Hi Guys! We've just got a translation for Korean. If you could share your opinion on the translation that would be able to pull the Korean language to our official version of Handsontable! You can find it at #5355 |
Hello. |
Hi @moonjoungyoung could you please paste a screen recording where this issue is replicable? |
Hello.
First of all, I am Korean.
I am trying to using this cool plugin.
When I input Korean in a cell, first character presents English always.
For example, I wanna write "한글", but the cell present "gㅏㄴ글".
"아이" -> "dㅏ이".
"도시" -> "eㅗ시".
Please fix it or answer to me how solve this problem.
Thank you.
The text was updated successfully, but these errors were encountered: