Wrong typing for beforeColumnMove

[guillaumep]

Documentation says about beforeColumnMove's arguments:

Name	Type	Description
columns	Array of numbers	Array of visual column indexes to be moved.
target	Number	Visual column index being a target for moved columns.

https://docs.handsontable.com/pro/5.0.2/Hooks.html#event:beforeColumnMove

But the typing in handsontable.d.ts has:

beforeColumnMove?: (startColumn: number, endColumn: number) => void;

It should be:

beforeColumnMove?: (columns: number[], target: number) => void;

[guillaumep]

Note: same thing is happening for beforeRowMove.

[AMBudnik]

Thank you for sharing @guillaumep

[guillaumep]

@wojciechczerniak @AMBudnik I approve of task #5094, where the issue I have logged should eventually be addressed, but can I suggest this current PR be merged in the sort term, so I and other Handsontable user can benefit from correct typings sooner?

[AMBudnik]

Hi @guillaumep

we haven't scheduled the epic nor the PR yet but will surely consider adding the PR first

[guillaumep]

@AMBudnik Is there something I can do to help this get merged?

It has already been one month the PR has been opened. Do other contributors to Handsontable have to wait this long too?

[AMBudnik]

I will try to push the code review for #5425 to the next milestone

[guillaumep]

@AMBudnik Thanks!

[AMBudnik]

Hi @guillaumep

the changes are published. Please update to 6.2.0