New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong typing for beforeColumnMove #5416

Closed
guillaumep opened this Issue Sep 25, 2018 · 8 comments

Comments

4 participants
@guillaumep
Contributor

guillaumep commented Sep 25, 2018

Documentation says about beforeColumnMove's arguments:

Name Type Description
columns Array of numbers Array of visual column indexes to be moved.
target Number Visual column index being a target for moved columns.

https://docs.handsontable.com/pro/5.0.2/Hooks.html#event:beforeColumnMove

But the typing in handsontable.d.ts has:

beforeColumnMove?: (startColumn: number, endColumn: number) => void;

It should be:

beforeColumnMove?: (columns: number[], target: number) => void;

@guillaumep

This comment has been minimized.

Contributor

guillaumep commented Sep 25, 2018

Note: same thing is happening for beforeRowMove.

guillaumep pushed a commit to guillaumep/handsontable that referenced this issue Sep 27, 2018

guillaumep pushed a commit to guillaumep/handsontable that referenced this issue Sep 27, 2018

@AMBudnik

This comment has been minimized.

Contributor

AMBudnik commented Sep 28, 2018

Thank you for sharing @guillaumep

@guillaumep

This comment has been minimized.

Contributor

guillaumep commented Oct 3, 2018

@wojciechczerniak @AMBudnik I approve of task #5094, where the issue I have logged should eventually be addressed, but can I suggest this current PR be merged in the sort term, so I and other Handsontable user can benefit from correct typings sooner?

@AMBudnik

This comment has been minimized.

Contributor

AMBudnik commented Oct 4, 2018

Hi @guillaumep

we haven't scheduled the epic nor the PR yet but will surely consider adding the PR first

@guillaumep

This comment has been minimized.

Contributor

guillaumep commented Oct 22, 2018

@AMBudnik Is there something I can do to help this get merged?

It has already been one month the PR has been opened. Do other contributors to Handsontable have to wait this long too?

@AMBudnik

This comment has been minimized.

Contributor

AMBudnik commented Oct 23, 2018

I will try to push the code review for #5425 to the next milestone

@guillaumep

This comment has been minimized.

Contributor

guillaumep commented Oct 28, 2018

@AMBudnik Thanks!

emilschutte added a commit to emilschutte/handsontable that referenced this issue Nov 13, 2018

Merge branch 'develop' into arrayMapper-removeItems-speedup
* develop: (25 commits)
  Upgrade Jest testing framework (handsontable#5564)
  Fix selection and context menu type annotations (handsontable#5307)
  Fix Korean language description and remove it from Readme.
  Add extra check for numbers in Copy event (handsontable#5548)
  Remove flag from dateEditor, because it falsely points to closing the editor when it's open. (handsontable#5520)
  Feature/fix unstable contextmenu tests (handsontable#5562)
  fix for issue with ERR_ADDRESS_INVALID error in issue handsontable#5558 (handsontable#5559)
  Sorting column by right mouse click is not possible (handsontable#5556)
  Fix issues related with broken develop (handsontable#5555)
  [Column sorting] Fix for plugin's index mapper (handsontable#5552)
  More strict TypeScript definition file (handsontable#5554)
  Fix typo in columnSorting i multiColumnSorting (handsontable#5547)
  The `ColumnSorting` plugin expose common parts to the `MultiColumnSorting` plugin (handsontable#5458)
  Remove external modules from jsdoc @Dependencies tag (handsontable#5546)
  Fix typings for beforeColumnMove and beforeRowMove (handsontable#5416) (handsontable#5425)
  correctly count the syncCalculationLimit in autoRowSize (handsontable#5530)
  Add beforeOnCellMouseDown hook to autoColumnSize to keep widths. (handsontable#5508)
  - Fix mobile tests (handsontable#5529)
  fixed typo[es-MX] (handsontable#5516)
  Update documentation URLs (handsontable#5519)
  ...
@AMBudnik

This comment has been minimized.

Contributor

AMBudnik commented Nov 14, 2018

Hi @guillaumep

the changes are published. Please update to 6.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment