Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.0.1+] Non-contiguous cell selection doesn't work properly #5427

Closed
mrpiotr-dev opened this issue Sep 28, 2018 · 0 comments
Closed

[5.0.1+] Non-contiguous cell selection doesn't work properly #5427

mrpiotr-dev opened this issue Sep 28, 2018 · 0 comments
Assignees
@mrpiotr-dev
Labels
Regression Issues that were created while adding new changes to the source code Status: Released
Milestone
October 2018

Comments

@mrpiotr-dev
Copy link
Contributor

Description

Changes introduced in v5.0.1 breaks non-contiguous selection.

Steps to reproduce

  1. Open demo
  2. Copy A1 to A2 using a keyboard shortcut
  3. Try select cells with pressed CMD / CTRL.

Demo

https://jsfiddle.net/doL49wkm/

Your environment

  • Handsontable version: 5.0.1+
  • Browser Name and version: any
  • Operating System: any
@mrpiotr-dev mrpiotr-dev added Priority: high Regression Issues that were created while adding new changes to the source code labels Sep 28, 2018
@mrpiotr-dev mrpiotr-dev added this to the October 2018 milestone Sep 28, 2018
@mrpiotr-dev mrpiotr-dev self-assigned this Sep 28, 2018
mrpiotr-dev added a commit that referenced this issue Sep 28, 2018
@mrpiotr-dev
Fix: keyStateObserved checks if a pressed key-combination contains br…
4107299 
…owser's reserved shortcut. #5427
mrpiotr-dev added a commit that referenced this issue Sep 28, 2018
@mrpiotr-dev
Changed: keyStateObserver and reserved shortcuts. #5427
5863432
mrpiotr-dev added a commit that referenced this issue Oct 1, 2018
@mrpiotr-dev
Fix: clearing pressed keys after window's blur event. #5427
1963335
mrpiotr-dev added a commit that referenced this issue Oct 1, 2018
@mrpiotr-dev
Added: test spec to prevent regression. #5427
b7106ce
@mrpiotr-dev mrpiotr-dev mentioned this issue Oct 1, 2018
Merged
1 task
mrpiotr-dev pushed a commit that referenced this issue Oct 1, 2018
@swistach
Blur event on the window should clear pressed keys in keyStateObserve…
723faa1 
…r. (#5432)

* Fix: keyStateObserved checks if a pressed key-combination contains browser's reserved shortcut. #5427

* Changed: keyStateObserver and reserved shortcuts. #5427

* Fix: clearing pressed keys after window's blur event. #5427

* Added: test spec to prevent regression. #5427
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrpiotr-dev mrpiotr-dev

Labels
Regression Issues that were created while adding new changes to the source code Status: Released
Projects
None yet
Milestone
October 2018
Development

No branches or pull requests
2 participants
@AMBudnik @mrpiotr-dev