Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The ColumnSorting plugin should expose common parts to the MultiColumnSorting plugin #5457

Closed
wszymanski opened this issue Oct 5, 2018 · 0 comments
Closed

The ColumnSorting plugin should expose common parts to the MultiColumnSorting plugin #5457

wszymanski opened this issue Oct 5, 2018 · 0 comments
Assignees
@wszymanski
Labels
Column sorting Plugin enhancement Status: Released
Milestone
November 2018

Comments

@wszymanski
Copy link
Contributor

wszymanski commented Oct 5, 2018 •
edited
Loading

Description

The MultiColumnSorting plugin should not duplicate the code. We should refactor.
@wszymanski wszymanski self-assigned this Oct 5, 2018
wszymanski added a commit that referenced this issue Oct 5, 2018
@wszymanski
WIP: First steps of refactoring #5457
38e2a73
wszymanski added a commit that referenced this issue Oct 5, 2018
@wszymanski
Fix for warn - will be used only once #5457
66b2787
@wszymanski wszymanski changed the title The MultiColumnSorting plugin should use common parts of the ColumnSorting plugin The ColumnSorting plugin should expose common parts to the MultiColumnSorting plugin Oct 5, 2018
wszymanski added a commit that referenced this issue Oct 5, 2018
@wszymanski
Fix for problem #5457
77ca8d3
wszymanski added a commit that referenced this issue Oct 5, 2018
@wszymanski
Proposal of action of a part of the code just for CE plugin #5457
b39dd83
wszymanski added a commit that referenced this issue Oct 5, 2018
@wszymanski
Fixed according to lint error #5457
438f661
wszymanski added a commit that referenced this issue Oct 5, 2018
@wszymanski
Changed main comparator engine & sort functions to be more general #5457
e021be0
@wszymanski wszymanski added this to the October 2018 milestone Oct 5, 2018
This was referenced Oct 5, 2018
Merged
Merged
wszymanski added a commit that referenced this issue Oct 8, 2018
@wszymanski
Updated comparators #5457
d514381
wszymanski added a commit that referenced this issue Oct 9, 2018
@wszymanski
Removed warns from the Handsontable CE - moving that to the PRO #5457
b8f0e6c
wszymanski added a commit that referenced this issue Oct 18, 2018
@wszymanski
WIP: Refactored from class to two pure functions #5457
68450cd
wszymanski added a commit that referenced this issue Oct 19, 2018
@wszymanski
Small refactor #5457
804f162
wszymanski added a commit that referenced this issue Oct 19, 2018
@wszymanski
Updated test for new structure #5457
b1a619e
wszymanski added a commit that referenced this issue Oct 23, 2018
@wszymanski
Removed test - related with https://github.com/handsontable/handsonta…
efbca92 
…ble/issues/5538 #5457
wszymanski added a commit that referenced this issue Oct 25, 2018
@wszymanski
Added registration of some functions #5457
b810d35
wszymanski added a commit that referenced this issue Oct 26, 2018
@wszymanski
WIP: Prototype for functions registration change #5457
cf1ce65
wszymanski added a commit that referenced this issue Oct 26, 2018
@wszymanski
Refactor & removed warns when config was invalid #5457
ddc2bbf
wszymanski added a commit that referenced this issue Oct 26, 2018
@wszymanski
Cleared unnecessary comments #5457
28cd986
wszymanski added a commit that referenced this issue Oct 26, 2018
@wszymanski
Removed one function #5457
eea071d
wszymanski added a commit that referenced this issue Oct 29, 2018
@wszymanski
Renamed helper functions #5457
be83637
wszymanski added a commit that referenced this issue Oct 29, 2018
@wszymanski
Created cervice #5457
bce7017
wszymanski added a commit that referenced this issue Oct 29, 2018
@wszymanski
Created service #5457
155b8ef
wszymanski added a commit that referenced this issue Oct 30, 2018
@wszymanski
Refator #5457
7928dee
wszymanski added a commit that referenced this issue Oct 30, 2018
@wszymanski
Missing test changes #5457
be70635
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wszymanski wszymanski

Labels
Column sorting Plugin enhancement Status: Released
Projects
None yet
Milestone
November 2018
Development

No branches or pull requests
3 participants
@wszymanski @wojciechczerniak @AMBudnik