Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mobile editor opens all the time (on click and scroll) - Android #5586

Closed
AMBudnik opened this issue Nov 15, 2018 · 0 comments
Closed

Mobile editor opens all the time (on click and scroll) - Android #5586

AMBudnik opened this issue Nov 15, 2018 · 0 comments
Assignees
@budnix
Labels
bug Mobile Status: Released
Milestone
December 2018

Comments

@AMBudnik
Copy link
Contributor

Description

Originated from #5479
The issue hasn't been fixed for the Android devices, on iOs it works well.

Steps to reproduce

  1. See Mobile editor opens all the time (on click and scroll) #5479

Your environment

  • Handsontable version: 6.2.0
  • Browser Name and version: Chrome
  • Operating System: Anroid
@wojciechczerniak wojciechczerniak added this to the December 2018 milestone Nov 27, 2018
@budnix budnix assigned budnix and unassigned jansiegel Nov 28, 2018
budnix added a commit that referenced this issue Dec 5, 2018
@budnix
Fix scrolling and broken editors for Android
ad01e74 
This commit fixes an issue about scrolling and fixes broken editors for
mobile devices with installed Android OS. Scrolling issue was fixed by
excluding refocus input after editor preparation (which is necessary for
IME). Broken editors (double tap) was fixed by excluding `mousedown` and
`mouseup` events when touch events are supported. This prevents firing
multiple times `onCellMouseUp` (and similar) hooks from Walkontable on a
single tap.

Additionally, some code for IE8 was removed.

Issue: #5586
@budnix budnix mentioned this issue Dec 5, 2018
Merged
6 tasks
@budnix budnix modified the milestones: December 2018, January 2019 Dec 5, 2018
budnix added a commit that referenced this issue Dec 6, 2018
@budnix
Fix scrolling and broken editors for Android (#5638)
63d3482 
This commit fixes an issue about scrolling and fixes broken editors for
mobile devices with installed Android OS. Scrolling issue was fixed by
excluding refocus input after editor preparation (which is necessary for
IME). Broken editors (double tap) was fixed by excluding `mousedown` and
`mouseup` events when touch events are supported. This prevents firing
multiple times `onCellMouseUp` (and similar) hooks from Walkontable on a
single tap.

Additionally, some code for IE8 was removed.

Issue: #5586
@budnix budnix mentioned this issue Dec 14, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@budnix budnix

Labels
bug Mobile Status: Released
Projects
None yet
Milestone
December 2018
Development

No branches or pull requests
4 participants
@budnix @wojciechczerniak @jansiegel @AMBudnik