You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If cell data is represented by an array, and the array data changes from a populated array to an empty array (or vice versa), the populateFromArray code produces a null change set. This happens because the value passed to duckSchema resolves differently for an empty array than for an array with elements. This happens in other scenarios as well, say where a populated array has string value selections and the changed strings are different lengths.
Steps to reproduce
Use an array data type for a column. I'm using a custom multiselect editor, which is how the array data is being edited.
Change the array selection from an array with at least one element to an empty array.
See that the changes are rejected because the changeset returned from populateFromArray is null.
Demo
I've created pull request #5676 with a unit test that demonstrates the issue.
Your environment
Handsontable version: 6.1.1
Browser Name and version: Chrome 70.0.3538.102
Operating System: Win10
The text was updated successfully, but these errors were encountered:
jdmcnair
added a commit
to jdmcnair/handsontable
that referenced
this issue
Dec 14, 2018
* test establishing problem described in issue #5675
* resolution for issue #5675: correct array handling in populateFromArray
* fixing lint error
* added further fix for handling array data and initial null value
* fixing lint issue
* removing junk comments
Description
If cell data is represented by an array, and the array data changes from a populated array to an empty array (or vice versa), the
populateFromArray
code produces a null change set. This happens because the value passed toduckSchema
resolves differently for an empty array than for an array with elements. This happens in other scenarios as well, say where a populated array has string value selections and the changed strings are different lengths.Steps to reproduce
populateFromArray
is null.Demo
I've created pull request #5676 with a unit test that demonstrates the issue.
Your environment
The text was updated successfully, but these errors were encountered: