Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handsontable won't work inside an iframe when initialized outside of it #5686

Closed
wojciechczerniak opened this issue Dec 20, 2018 · 2 comments
Closed

Handsontable won't work inside an iframe when initialized outside of it #5686

wojciechczerniak opened this issue Dec 20, 2018 · 2 comments
Assignees
@mrpiotr-dev
Labels
Status: Released Type: Improvement suggestion
Milestone
January 2019

Comments

@wojciechczerniak
Copy link
Contributor

Description

Handsontable doesn't work when created in an iframe document of a document that it has been loaded into.

The proposed fix is to use document (ownerDocument) of passed .H wrapper, rather than to rely on global document variable.

Steps to reproduce

  1. Create an <iframe> with Handsontable container inside
  2. Initialize Handsontable on that container
  3. Check console for error

Demo

https://codepen.io/jacekbogdanski/pen/pqEaOY

Your environment

  • Handsontable version: 6.2.2
  • Browser Name and version: Firefox
  • Operating System: OSX
@wojciechczerniak wojciechczerniak added this to the January 2019 milestone Dec 20, 2018
@marek-baranowski
Copy link

+1

I would really appreciate having this fixed as this is a blocker - we have to use Handsontable inside an iframe.

mrpiotr-dev added a commit that referenced this issue Jan 8, 2019
@mrpiotr-dev
WIP. Should be able to initialize Handsontable in iframe. #5686
8799933
mrpiotr-dev added a commit that referenced this issue Jan 10, 2019
@mrpiotr-dev
WIP. Removing globals (window, document) from code. #5686
9887cbe
mrpiotr-dev added a commit that referenced this issue Jan 11, 2019
@mrpiotr-dev
WIP. Replacement of window and document with defaultView and ownerDoc…
10825b4 
…ument in Walkontable, editors and several plugins. #5686
mrpiotr-dev added a commit that referenced this issue Jan 14, 2019
@mrpiotr-dev
WIP. Rest of plugins + renderers. #5686
521105d
mrpiotr-dev added a commit that referenced this issue Jan 15, 2019
@mrpiotr-dev
WIP. Tweaks and changes to run HOT in iframe without errors. #5686
9ee16e6
mrpiotr-dev added a commit that referenced this issue Jan 15, 2019
@mrpiotr-dev
From #5686 WIP - 15.01
75dd8b3
mrpiotr-dev added a commit that referenced this issue Jan 17, 2019
@mrpiotr-dev
Changed: helpers names, window/document as a context as the last argu…
8bd89cf 
…ment in helpers. #5686
@mrpiotr-dev mrpiotr-dev mentioned this issue Jan 17, 2019
Merged
1 task
mrpiotr-dev added a commit that referenced this issue Jan 17, 2019
@mrpiotr-dev
Final changes and tweaks before CR. #5686
0b0da10
mrpiotr-dev added a commit that referenced this issue Jan 18, 2019
@mrpiotr-dev
Changes after the CR - added missing arguments. #5686
1729426
mrpiotr-dev added a commit that referenced this issue Jan 21, 2019
@mrpiotr-dev
Changes after CR + added ts definitions. #5686
de0d5c6
mrpiotr-dev added a commit that referenced this issue Jan 23, 2019
@mrpiotr-dev
Changes after CR: tweak for getting scrollable element. #5686
c8f6295
mrpiotr-dev added a commit that referenced this issue Jan 25, 2019
@mrpiotr-dev
Small adjustments after CR. Changed getScrollableElement. Removed com…
d2bac9b 
…ment from overlay/_base. #5686
mrpiotr-dev pushed a commit that referenced this issue Jan 25, 2019
@swistach
Handsontable should work properly in <iframe> (#5723)
43f7ce1 
* WIP. Should be able to initialize Handsontable in iframe. #5686

* WIP. Removing globals (window, document) from code. #5686

* WIP. Replacement of window and document with defaultView and ownerDocument in Walkontable, editors and several plugins. #5686

* WIP. Rest of plugins + renderers. #5686

* WIP. Tweaks and changes to run HOT in iframe without errors. #5686

* Changed: helpers names, window/document as a context as the last argument in helpers. #5686

* Final changes and tweaks before CR. #5686

* Changes after the CR - added missing arguments. #5686

* Update src/helpers/feature.js

Co-Authored-By: swistach <swistach@users.noreply.github.com>

* Changes after CR + added ts definitions. #5686

* Changes after CR: tweak for getting scrollable element. #5686

* Small adjustments after CR. Changed getScrollableElement. Removed comment from overlay/_base. #5686
@mrpiotr-dev mrpiotr-dev mentioned this issue Jan 28, 2019
Merged
1 task
@AMBudnik
Copy link
Contributor

AMBudnik commented Mar 6, 2019

@marek-baranowski just released it in v 7.0.0

@AMBudnik AMBudnik closed this as completed Mar 6, 2019
@wszymanski wszymanski mentioned this issue Feb 24, 2020
Closed
68 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrpiotr-dev mrpiotr-dev

Labels
Status: Released Type: Improvement suggestion
Projects
None yet
Milestone
January 2019
Development

No branches or pull requests
4 participants
@marek-baranowski @wojciechczerniak @AMBudnik @mrpiotr-dev