Handsontable should work properly in <iframe> #5723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ument in Walkontable, editors and several plugins. #5686
budnix
reviewed
Jan 18, 2019
Co-Authored-By: swistach <swistach@users.noreply.github.com>
wszymanski
approved these changes
Jan 21, 2019
wszymanski
suggested changes
Jan 21, 2019
wszymanski
reviewed
Jan 21, 2019
wszymanski
suggested changes
Jan 25, 2019
…ment from overlay/_base. #5686
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently, we use global
windowanddocumentto do every DOM operation what could make for bugs.How has this been tested?
Use the following example https://jsfiddle.net/cagrLk4z/
Types of changes
Related issue(s):