Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When we again on the same cell with RMB we get a browser menu #6218

Closed
AMBudnik opened this issue Aug 20, 2019 · 7 comments
Closed

When we again on the same cell with RMB we get a browser menu #6218

AMBudnik opened this issue Aug 20, 2019 · 7 comments
Labels
bug Context menu Plugin Status: Released

Comments

@AMBudnik
Copy link
Contributor

Description

When we click RMB on a text inside a cell twice we get two menus: browser and the context menu.

image

image

The issue seems to be gone if we click on an empty space inside a cell.

Steps to reproduce

  1. Try to click on the same cell using RMB.
    You should be pixel perfect and use RMB on the same pixel on a text inside a cell.

Demo

any context menu example https://handsontable.com/docs/7.1.1/demo-context-menu.html

Your environment

  • Handsontable version: 7.1.1
    Doesn't seem to be version related
  • Browser Name and version: Chrome 76
  • Operating System: Windows 10
@mrpiotr-dev mrpiotr-dev mentioned this issue Oct 2, 2019
Closed
5 tasks
@AMBudnik AMBudnik mentioned this issue Oct 10, 2019
Closed
@aninde
Copy link
Contributor

aninde commented Nov 15, 2019

It was difficult to reproduce. IMHO it is better on 7.3.0, but I'm not sure about assumptions. @AMBudnik can you check it again?

Demo
https://jsfiddle.net/aninde/42w167bh/

@mrpiotr-dev mrpiotr-dev added this to the October 2019 milestone Nov 18, 2019
@mrpiotr-dev mrpiotr-dev self-assigned this Nov 18, 2019
@AMBudnik
Copy link
Contributor Author

It's clear how to replicate this issue now.

  1. Open a context menu (Handsontable)
  2. Click the RMBon the line of our context menu. If you move the pointer slowly to the top you will notice that the pointer changes when you hover over the line (border) of the context menu. That's the place to click RMB

image

GIF

Replicable in 7.3.0 https://jsfiddle.net/oL6egc0x/

@mrpiotr-dev mrpiotr-dev removed their assignment Nov 18, 2019
@mrpiotr-dev mrpiotr-dev removed this from the October 2019 milestone Nov 18, 2019
mrpiotr-dev added a commit that referenced this issue Nov 18, 2019
@mrpiotr-dev
WIP. Changed: contextmenu's borders are now a part of particular cell…
79cc19c 
…s. Removed 'magic' calculations to adjust .htCore borders. #6218
@mrpiotr-dev mrpiotr-dev mentioned this issue Nov 19, 2019
Closed
1 task
mrpiotr-dev added a commit that referenced this issue Nov 19, 2019
@mrpiotr-dev
Changed: contextMenu shouldn't add any additional/'magic' pixels to t…
058b30f 
…he context menu wrapper. #6218
@mrpiotr-dev mrpiotr-dev self-assigned this Nov 20, 2019
mrpiotr-dev added a commit that referenced this issue Nov 20, 2019
@mrpiotr-dev
Changes after CR: using helpers instead of the same fragment of code …
6321caf 
…in many places. Added: TS definitions for new dom helpers. #6218
mrpiotr-dev added a commit that referenced this issue Nov 20, 2019
@mrpiotr-dev
Changes after CR: using helpers instead of the same fragment of code …
0275a3b 
…in many places. Added: TS definitions for new dom helpers. #6218
mrpiotr-dev pushed a commit that referenced this issue Nov 20, 2019
@swistach @budnix
Test if frame.frameElement is readable (#6479)
c599a4d 
* Changed: before we try to get frameElement we have to verify prototype of frame.parent. #6478

* Changes after CR: using helpers instead of the same fragment of code in many places. Added: TS definitions for new dom helpers. #6218

* Added: missing change after manual resolving of conflict after cherry pick. #6478

* Apply suggestions from code review

Co-Authored-By: Krzysztof Budnik <571316+budnix@users.noreply.github.com>
mrpiotr-dev pushed a commit that referenced this issue Nov 20, 2019
@swistach @budnix @mrpiotr-dev
Test if frame.frameElement is readable (#6479)
d3689b1 
* Changed: before we try to get frameElement we have to verify prototype of frame.parent. #6478

* Changes after CR: using helpers instead of the same fragment of code in many places. Added: TS definitions for new dom helpers. #6218

* Added: missing change after manual resolving of conflict after cherry pick. #6478

* Apply suggestions from code review

Co-Authored-By: Krzysztof Budnik <571316+budnix@users.noreply.github.com>
@aninde
Copy link
Contributor

aninde commented Nov 26, 2019

This bug is still repricable in latesst version on 7.3.0 https://jsfiddle.net/g7b64pkv/

@wojciechczerniak
Copy link
Contributor

Yup, PR #6484 was not merged and this is marked for v8.0.0-beta

@mrpiotr-dev mrpiotr-dev mentioned this issue Feb 26, 2020
Merged
1 task
pnowak pushed a commit that referenced this issue Apr 17, 2020
@swistach
Clicking in a contextmenu's border should not open the native context…
cb13da9 
… menu (#6732)

* #6218 - Changes the order of actions in the added spec
@aninde aninde mentioned this issue Jun 10, 2020
Closed
55 tasks
@aninde
Copy link
Contributor

aninde commented Jul 3, 2020

In my opinion, it's fixed in 8.0.0-beta2-rev18 https://jsfiddle.net/s3ujwn7g/1/. Tested on Firefox 77, Chrome 83 and Safari 13.1.1 / macOS Catalina 10.15.5

This issue requires high precision and I would like to be 100% sure. @AMBudnik can you retest it?
rev18-6218

@wojciechczerniak wojciechczerniak mentioned this issue Jul 3, 2020
Closed
204 tasks
@AMBudnik
Copy link
Contributor Author

AMBudnik commented Jul 6, 2020

@aninde that was a tricky one. And yes, it is fixed in 8.0.0-beta2-rev18 - when we click the border there's no system menu.

@aninde
Copy link
Contributor

aninde commented Jul 20, 2020

This issue remains fixed with pre-8.0.0-rev1 https://jsfiddle.net/aninde/7jdt2shg/.

@AMBudnik AMBudnik closed this as completed Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Context menu Plugin Status: Released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@wojciechczerniak @AMBudnik @mrpiotr-dev @aninde