Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.1.1] Disappearing column header with auto height #6302

Closed
jacekbogdanski opened this issue Sep 30, 2019 · 6 comments
Closed

[7.1.1] Disappearing column header with auto height #6302

jacekbogdanski opened this issue Sep 30, 2019 · 6 comments
Assignees
Labels
bug Regression Issues that were created while adding new changes to the source code Status: Released
Milestone

Comments

@jacekbogdanski
Copy link

jacekbogdanski commented Sep 30, 2019

Description

Once you set height: 'auto' with col headers enabled, headers get visibility: hidden CSS property. It seems like a regression starting from 7.1.1.

Steps to reproduce

  1. Initialize Handsontable instance with configuration:
new Handsontable( container, {
  colHeaders: true,
  rowHeaders: true,
  height: 'auto'
} );
  1. Verify Handsontable instance in a browser.

Demo

https://codepen.io/jacekbogdanski/pen/mZvyYb

You can also change Handsontable version to 7.1.0 to see it has been working correctly.

Your environment

  • Handsontable version: 7.1.1
  • Browser Name and version: Chrome 76.0.3809.132 (Official Build) (64-bit)
  • Operating System: Linux Fedora 30
@AMBudnik AMBudnik added the bug label Oct 1, 2019
@wojciechczerniak wojciechczerniak added this to the October 2019 milestone Oct 1, 2019
@wojciechczerniak wojciechczerniak added the Regression Issues that were created while adding new changes to the source code label Oct 1, 2019
@wojciechczerniak wojciechczerniak changed the title Disappearing column header with auto height [7.1.1] Disappearing column header with auto height Oct 7, 2019
@wojciechczerniak
Copy link
Contributor

Note: We should test #6213 with after we fix this issue

@aninde
Copy link
Contributor

aninde commented Oct 9, 2019

@jacekbogdanski this bug will be fixed in 7.1.2 7.2.0 version. The new version will be released next week.
When height: 'auto' column headers are still visible.

Screenshot 2019-10-09 at 11 30 46

Demo:
v. 7.1.2 7.2.0 https://jsfiddle.net/aninde/vq0m3ta4/

@jacekbogdanski
Copy link
Author

Awesome, thanks for the quick response :)

@ispyhumanfly
Copy link

Very much looking forward to this fix!

@aninde
Copy link
Contributor

aninde commented Oct 10, 2019

@ispyhumanfly if the new version passes the tests, we plan to release it on Tuesday, October 15.

@AMBudnik
Copy link
Contributor

Hey @jacekbogdanski @ispyhumanfly we've just release Handsontable 7.2.0. Where this issue is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Regression Issues that were created while adding new changes to the source code Status: Released
Projects
None yet
Development

No branches or pull requests

6 participants