Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollback changes in TS #6351

Closed
pnowak opened this issue Oct 17, 2019 · 0 comments
Closed

Rollback changes in TS #6351

pnowak opened this issue Oct 17, 2019 · 0 comments
Assignees
@pnowak
Labels
Status: Released TypeScript
Milestone
October 2019

Comments

@pnowak
Copy link
Contributor

pnowak commented Oct 17, 2019 •
edited
Loading

Description

We need to withdraw a rewrite from Base to BasePlugin, BaseEditor and BaseRenderer in this PR #6144. These changes were a breaking change.

Steps to reproduce

  1. Compatibilities with new version 7.2.0 vue-handsontable-official#137

Your environment

  • Handsontable version: 7.2.0
  • Browser Name and version:
  • Operating System:
@pnowak pnowak added this to the October 2019 milestone Oct 17, 2019
@pnowak pnowak self-assigned this Oct 17, 2019
pnowak added a commit that referenced this issue Oct 17, 2019
@pnowak
Rollbacked to Base #6351
dd70139
@pnowak pnowak mentioned this issue Oct 17, 2019
Merged
6 tasks
pnowak added a commit that referenced this issue Oct 21, 2019
@pnowak
Rollbacked to Base #6351 (#6352)
72f1c4d
jansiegel pushed a commit that referenced this issue Oct 23, 2019
@pnowak @jansiegel
Rollbacked to Base #6351 (#6352)
fffd61a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pnowak pnowak

Labels
Status: Released TypeScript
Projects
None yet
Milestone
October 2019
Development

No branches or pull requests
2 participants
@pnowak @AMBudnik