Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

columnSummary ignore 0 in min options #6385

Closed
pnowak opened this issue Oct 25, 2019 · 6 comments · Fixed by #9825 or #9934
Closed

columnSummary ignore 0 in min options #6385

pnowak opened this issue Oct 25, 2019 · 6 comments · Fixed by #9825 or #9934
Assignees
@jansiegel
Labels
bug Status: Released Summary calculations Plugin
Milestone
12.1.3 (September...

Comments

@pnowak
Copy link
Contributor

pnowak commented Oct 25, 2019 •
edited
Loading

Description

It seems that value 0 isn't considered in min options. Just like 0 wasn't a value. Thanks count option - https://jsfiddle.net/y85grszo/2/ - we can see that 0 doesn't belong to a non-empty value.
But if edit 0 the calculation min is correct to 0.

Demo

https://jsfiddle.net/y85grszo

Your environment

  • Handsontable version:
  • Browser Name and version:
  • Operating System:
@AMBudnik
Copy link
Contributor

If we type only 0 we get the Not enough data return for both min and max. Sum works well and all min/max work well for negative numbers.

image
https://jsfiddle.net/d1jLvupk/1/

@AMBudnik
Copy link
Contributor

AMBudnik commented Aug 18, 2020 •
edited
Loading

The issue is still replicable after updating to v8.0.0 https://jsfiddle.net/zxk6nghr/, ad 8.2.0 https://jsfiddle.net/handsoncode/z38aLhcx/

@krzysztofspilka
Copy link
Member

krzysztofspilka commented Jun 9, 2022 •
edited
Loading

@AMBudnik is it still reproducible with 12.0.1 or later?

@AMBudnik
Copy link
Contributor

@krzysztofspilka, yes it is. I've updated the demo to v12.0.1 and still 7 is considered the lowest number from the 0, 7, 14 array.

Screenshot 2022-06-10 at 08 43 01

Demo https://jsfiddle.net/s8mefgkp/1/

@krzysztofspilka krzysztofspilka added this to the 12.2 (September 2022) milestone Aug 18, 2022
@jansiegel jansiegel self-assigned this Aug 24, 2022
jansiegel added a commit that referenced this issue Aug 24, 2022
@jansiegel
Fix an issue with "0" initial dataset values weren't taken into accou…
98724ff 
…nt in the "min", "max" and "count" functions of the column summary plugin. #6385
@jansiegel jansiegel mentioned this issue Aug 24, 2022
Merged
12 tasks
jansiegel added a commit that referenced this issue Aug 24, 2022
@jansiegel
Fix an issue with 0 initial dataset values in the Column Summary pl…
3a3a3a9 
…ugin. (#9825)

* Fix an issue with "0" initial dataset values weren't taken into account in the "min", "max" and "count" functions of the column summary plugin. #6385

* Add the changelog entry.
@jansiegel jansiegel linked a pull request Aug 26, 2022 that will close this issue
Fix an issue with 0 initial dataset values in the Column Summary plugin. #9825
Merged
12 tasks
@budnix budnix mentioned this issue Sep 21, 2022
Merged
5 tasks
@aninde
Copy link
Contributor

aninde commented Sep 21, 2022

This issue will be fixed by the upcoming v12.1.3 https://jsfiddle.net/ocshdk2m/

@aninde aninde reopened this Sep 21, 2022
@AMBudnik
Copy link
Contributor

I'm closing this issue as fixed in Handsontable v12.1.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jansiegel jansiegel

Labels
bug Status: Released Summary calculations Plugin
Projects
None yet
Milestone
12.1.3 (September 22, 2022)
5 participants
@pnowak @jansiegel @krzysztofspilka @AMBudnik @aninde