[8.0.0-svg] Selection on printed Handsontable

[aninde]

Description

Found during testing #6467.

Selection does print without fillHandle.
Excel does not print selection.
@wojciechczerniak agreed it should not be visible on the print in Handsontable.

Probably this bug occurs since the beginning but was hide on prints. Borders and selection were part of the background. Changes related to a new way of drawing SVG borders discover it.
This occur on every SVG PR
#6157
testing svg-stage1-#6157.pdf
#6593
testing svg-stage2-#6593.pdf
#6594
testing svg-stage2-#6594.pdf

Your environment

• Handsontable version: 8.0.0-svg
• Browser Name and version: any
• Operating System: macOS Catalina, but shouldn't be related

[warpech]

We discussed on Slack: https://handsoncode.slack.com/archives/C4PV4S33Q/p1578566904004800

The desicion made by @krzysztofspilka is to do a short-term solution to the problem which basically replicates the behavior of 7.x. That is: hide all SVG borders using CSS.

Unfortunately, this solution is against what was suggested here #5298 (comment), but I guess we will have to do it at least for now.

I think that the long-term solution will require specifying and implementing a new border setting printable, which custom borders would set to true and selections would set to false.

[warpech]

Fixed according to the solution described above in the commit cd42f84, part of the PR #6157

[aninde]

Ok, it works beautifully, according to the assumptions. No customBorders or selection can be seen on the print, but there is an empty space after square of fillHandle. This is regression, because it wasn't there on 7+ versions This square didn't belong to scope, but in my opinion it doesn't look good. What you think about it @wojciechczerniak ?

Print screen from browser

Print screen from print
testing svg-stage3-#6157.pdf

[wojciechczerniak]

This square didn't belong to scope, but in my opinion it doesn't look good. What you think about it @wojciechczerniak ?

Looks like the fix in cd42f84 wasn't complete. This square is a part of fill handle which should be hidden in print as well.

[warpech]

Looks like the fix in cd42f84 wasn't complete. This square is a part of fill handle which should be hidden in print as well.

The fix was complete in that regard. As @aninde says, the empty hole insted of the fill handle is not a regression, because:

• the same hole exists in 7.x
• the hole is not rendered using SVG

I can make a fix for that in my branch, but I wanted to double confirm with you, because fixing the visual glitch that exists in 7.x is both a breaking change and not in scope of SVG borders. I hope that doesn't sound picky :)

[wojciechczerniak]

Sorry, I thought I've read it wasn't there before.

I did a check myself in v7. It IS the fill handle. The web browser changed the background color to white. The default browser setting for "print background color" is no to limit ink waste.

You're right it's out of scope for this PR.

[aninde]

Thank you so much for double checking, the bug is actually on version 7+. Is reported https://github.com/handsontable/dev-handsontable/issues/352. So, IMO we should close this issue, cause fix in cd42f84 was complete and correct with assumptions and scope.