Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[svg] selection, fill and autoFill covers fixedBorder or frozen-border #6628

Closed
aninde opened this issue Jan 10, 2020 · 2 comments
Closed

[svg] selection, fill and autoFill covers fixedBorder or frozen-border #6628

aninde opened this issue Jan 10, 2020 · 2 comments
Assignees
Labels
bug Custom borders Plugin Fixing / Freezing Plugin Regression Issues that were created while adding new changes to the source code Status: To be discussed Plugin

Comments

@aninde
Copy link
Contributor

aninde commented Jan 10, 2020

Description

On 8.0.0-svg related PR's (#6594 & #6593) selection, fill and autoFill covers fixedBorder or frozen-border. Previous fixed border covers a most of objects.
On every image firs and second rows are fixed.
v. 7.3.0 https://jsfiddle.net/3fmhgjn5/
Fixed border beetween row 2 and row 3 cover selection, fill and autofil. It works like that on Excel on Google Spreadsheet.
Screenshot 2020-01-10 at 17 05 35

v 8.0.0.-svg https://jsfiddle.net/sr61h4m3/1/
selection, fill and autofil covers fixed border. Even custom settings.
Screenshot 2020-01-10 at 17 04 50

Excel

Screenshot 2020-01-10 at 17 27 33

Google spreadsheet

Screenshot 2020-01-10 at 17 28 47

Case 1

fixedRowsTop

Case 2

fixedColumnLeft/frozen column

v. 7.3.0
Screenshot 2020-01-10 at 17 34 05

v 8.0.0.-svg
Screenshot 2020-01-10 at 17 33 21

Case 3

fixedRowsBottom
row 98 is fixed
v. 7.3.0
Screenshot 2020-01-10 at 17 35 09

v 8.0.0.-svg
Screenshot 2020-01-10 at 17 34 52

We have no assumptions, but due to the fact that our stable version, Excel and Google spreadsheet have a different order, I report it as regression.

@aninde aninde added bug Custom borders Plugin Status: To be discussed Plugin Fixing / Freezing Plugin Regression Issues that were created while adding new changes to the source code labels Jan 10, 2020
@aninde aninde changed the title [8.0.0.-svg] selection, fill and autoFill covers fixedBorder or frozen-border [8.0.0-svg] selection, fill and autoFill covers fixedBorder or frozen-border Jan 10, 2020
@warpech
Copy link
Member

warpech commented Jan 14, 2020

Thank you @aninde for reporting. I think this is covered by #6639.

In the knowledge base, we have defined how borders overlap the "Frozen line": https://kb.handsontable.com/display/HAN/Borders. The same rule applies to "custom borders" and "selection borders".

@warpech warpech self-assigned this Jan 14, 2020
@AMBudnik AMBudnik changed the title [8.0.0-svg] selection, fill and autoFill covers fixedBorder or frozen-border [svg] selection, fill and autoFill covers fixedBorder or frozen-border May 11, 2020
@krzysztofspilka
Copy link
Member

This is an issue reported for the SVG borders project, which was rejected and won't be implemented in Handsontable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Custom borders Plugin Fixing / Freezing Plugin Regression Issues that were created while adding new changes to the source code Status: To be discussed Plugin
Projects
None yet
Development

No branches or pull requests

3 participants