Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[svg] Introduce "Frozen line" to mark the edge of fixed rows/columns #6639

Closed
warpech opened this issue Jan 14, 2020 · 3 comments
Closed

[svg] Introduce "Frozen line" to mark the edge of fixed rows/columns #6639

warpech opened this issue Jan 14, 2020 · 3 comments
Assignees
@warpech
Labels
Breaking change Core: Walkontable Plugin

Comments

@warpech
Copy link
Member

warpech commented Jan 14, 2020 •
edited

Description

The SVG borders PR (#6157) contains a visual breaking change:

When scrolling horizontally or vertically on the border fixed/frozen col/row, the line selection or right border of the selected cell if the border is bigger than 1 px.
Check out demo https://codesandbox.io/s/gifted-noyce-hdvx5
svg-stage2-6594-ff

More details about that problem here by @aninde: #6594 (comment)

@krzysztofspilka, @wojciechczerniak and I have discussed how to change the spec to fix the problem reported in #6594 (comment).

Our conclusion is to introduce a new feature in this PR: "Frozen line" [1]. The borders (incl. custom borders and selection borders) will not be rendered on the frozen line, except for the parts of borders that are thicker than the frozen line [2].

This will be fixed within the SVG borders PR #6157.

Links to the updated specs:

🚨 This is a (Visual) breaking change
@warpech warpech mentioned this issue Jan 14, 2020
Merged
6 tasks
@warpech warpech self-assigned this Jan 14, 2020
@warpech warpech mentioned this issue Jan 14, 2020
Closed
@aninde aninde mentioned this issue Jan 15, 2020
Closed
9 tasks
@aninde aninde mentioned this issue Jan 16, 2020
Closed
15 tasks
@warpech
Copy link
Member Author

warpech commented Jan 16, 2020

I have an implementation that I will soon push to the PR. However, one change was proposed and I will decide if I can make it in 8.0.0: #6651

@warpech warpech mentioned this issue Jan 20, 2020
Closed
warpech added a commit that referenced this issue Jan 20, 2020
@warpech
change: implement Frozen line (#6639)
7cad0e6 
The frozen line is implemented as a special case of gridline, with the color soldered in CSS.

This commit adds a class name ""wtTableCornerCell" for the corner cell in the top left overlay. This allows to write specific CSS selectors for that cell.
@warpech
Copy link
Member Author

warpech commented Jan 20, 2020 •
edited

Implemented in PR #6157 (commit 7cad0e6).

The task #6651 will be done at some other time.

@wojciechczerniak wojciechczerniak changed the title [8.0.0-svg] Introduce "Frozen line" to mark the edge of fixed rows/columns [svg] Introduce "Frozen line" to mark the edge of fixed rows/columns May 19, 2020
@warpech warpech mentioned this issue Jan 13, 2022
Closed
6 tasks
@warpech
Copy link
Member Author

warpech commented Jan 13, 2022

Closing as the SVG PR was closed. Explanation in #6157 (comment)

@warpech warpech closed this as completed Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@warpech warpech

Labels
Breaking change Core: Walkontable Plugin
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@warpech @mrpiotr-dev @aninde