Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.0.0-svg] walkontable.selection e2e test do not pass only on Firefox #6644

Closed
aninde opened this issue Jan 16, 2020 · 2 comments
Closed

[8.0.0-svg] walkontable.selection e2e test do not pass only on Firefox #6644

aninde opened this issue Jan 16, 2020 · 2 comments
Assignees
@warpech
Labels
bug Core: Walkontable Plugin Firefox Tests: E2E

Comments

@aninde
Copy link
Contributor

aninde commented Jan 16, 2020

Description

One walkontable.selection test do not pass only in Firefox. It passes on Chrome, Safari and Edge.

Walkontable.Selection > should apply changed settings of a highlight (mobile browser)
Expected '' to equal 'rgb(255, 0, 0)'.
Expected '' to equal 'rgb(255, 0, 0)'.
Expected '' to equal 'rgb(127, 124, 0)'.
Expected '' to equal 'rgb(127, 124, 0)'.

Screenshot 2020-01-16 at 09 58 41

Steps to reproduce

run newly builded walkontable.dump after building handsontable and walkontable in Firefox

Your environment

  • Handsontable version: 8.0.0-svg builded from branch origin/feature/issue-6064)
  • Browser Name and version: Firefox 72
  • Operating System: macOS
@aninde aninde added bug Core: Walkontable Plugin Regression Issues that were created while adding new changes to the source code Tests: E2E labels Jan 16, 2020
@warpech warpech self-assigned this Jan 16, 2020
warpech added a commit that referenced this issue Jan 16, 2020
@warpech
test: fix test in Firefox (#6644)
9507c2d 
In Firefox, you only get the computed border color for each edge separately
@warpech
Copy link
Member

warpech commented Jan 16, 2020

Fixed in 9507c2d, as part of #6157

@aninde aninde mentioned this issue Jan 16, 2020
Closed
15 tasks
@aninde
Copy link
Contributor Author

aninde commented Jan 16, 2020

Thank you for the quick repair, everything works on Firefox, Safari, Chrome and Edge. I close the issue.
Screenshot 2020-01-16 at 13 41 19

@aninde aninde closed this as completed Jan 16, 2020
@aninde aninde added Firefox and removed Regression Issues that were created while adding new changes to the source code labels Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@warpech warpech

Labels
bug Core: Walkontable Plugin Firefox Tests: E2E
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@warpech @aninde