Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[svg] selection flickers when autofill is on last column #6671

Closed
aninde opened this issue Jan 28, 2020 · 2 comments
Closed

[svg] selection flickers when autofill is on last column #6671

aninde opened this issue Jan 28, 2020 · 2 comments
Assignees
@warpech
Labels
bug Core: Selection Plugin Regression Issues that were created while adding new changes to the source code

Comments

@aninde
Copy link
Contributor

aninde commented Jan 28, 2020 •
edited

Description

When we select the last column the autofill corner in the previous version is shifted so that it does not affect the table viewport and no horizontal scrollbar appears. It produces funny glitches

7.3.0
7 3 0

PR
PR

Found by playing with stretching demo https://handsontable.com/docs/7.3.0/demo-stretching.html

It produces funny glitches
Kapture 2020-01-24 at 13 31 13

Demo

https://jsfiddle.net/aninde/Ltsa21p9/ - 8.0.0-svg

Your environment

Handsontable version: 8.0.0-svg
Browser Name and version: any
Operating System: any

Originally posted by @budnix in #6157 (comment)
@aninde aninde added Core: Selection Plugin Regression Issues that were created while adding new changes to the source code bug labels Jan 28, 2020
@warpech warpech self-assigned this Jan 28, 2020
@aninde aninde changed the title [8.0.0-svg] selection flickers when autofil is on last column [8.0.0-svg] selection flickers when autofill is on last column Jan 28, 2020
This was referenced Jan 28, 2020
Closed
Closed
Closed
warpech added a commit that referenced this issue Feb 9, 2020
@warpech
bugfix: selection flickers when autofill is on last stretched column (#…
0b8c9fa 
…6671)

the problem was coming from two things:
1. the corner position did not take into the account the scrolbar width
2. in change fe829b2, the default row header width is changed to 51 pixels, and column stretcher takes that into account
warpech added a commit that referenced this issue Feb 18, 2020
@warpech
change: drawing of borders on the gridlines (#6646, #6673, #6671, #6651)
59b71c2 
Bugfix #6646 (Loss of right border of rowHeader while scrolling when fixedRowsTop and fixedRowsBottom
are enabled). The solution was to remove various factors that caused varied size of headers.
There are no longer classes `innerBorderTop` and `innerBorderLeft`. This change simplified the code,
but could have affected various plugins, such NestedHeaders. All plugins should be tested to be sure
that there are no regressions.

Bugfix #6673. First column is now 1px wider than before (as reported by outerWidth), to accommodate for
the fact that it draws border on the left.

Bugfix #6671 (selection flickers when autofill is on last stretched column). The cause of the problem
was that the corner position did not take into the account the scrollbar width

Feature #6651. The border is rendered on the gridline according to the new specification, and the frozen
line has a new color #5d6365.

Additional changes:

1. in `walkontable.css`, change `line-height` of `.colHeader` to a slightly smaller value that results in
the same row-height in Firefox as in Chrome on Windows

2. in `walkontable.css`, removed declaration of default <col> width 50px. Now, the same value comes from
Walkontable setting `defaultColumnWidth`. The only way to overwrite it is by providing the new value in the JS
settings object. This is more consistent.

3. make AutoColumnSize results deterministic across all tested browsers. In tests, use `toEqual` instead
of `arrayContaining` or `toBeAroundValue`.

4. in HeaderTooltips, hardcode the text width threshold for the `onlyTrimmed` to 50px. This change is
explained in a comment. Related issue: #6708

5. fix rendering of GhostTable. Before this commit, GhostTable was sometimes rendered without borders
on all sides

6. in all places where 1px is added or subtracted to accommodate for the gridline, use a constant
GRIDLINE_WIDTH defined in `utils/gridline.js`

7. in frozen line tests, change `elem.innerText` to `elem.textContent`, because the former was sometimes
empty in Safari

8. performance: `getCellFn` is now provided as configuration to `BorderRenderer`, instead of as
a parameter to `BorderRenderer.render`
@warpech
Copy link
Member

warpech commented Feb 18, 2020

Fixed in 59b71c2, as part of the SVG borders PR (#6157).

@AMBudnik AMBudnik changed the title [8.0.0-svg] selection flickers when autofill is on last column [svg] selection flickers when autofill is on last column May 11, 2020
@krzysztofspilka
Copy link
Member

krzysztofspilka commented Jul 21, 2021 •
edited

This is an issue reported for the SVG borders project, which was rejected and won't be implemented in Handsontable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@warpech warpech

Labels
bug Core: Selection Plugin Regression Issues that were created while adding new changes to the source code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@warpech @krzysztofspilka @aninde