Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.0.0-beta2-rev1] When nestedRows are enabled we cannot call updateSettings #6855

Closed
AMBudnik opened this issue May 8, 2020 · 3 comments
Closed

[8.0.0-beta2-rev1] When nestedRows are enabled we cannot call updateSettings #6855

AMBudnik opened this issue May 8, 2020 · 3 comments
Assignees
@jansiegel
Labels
bug Core: Update settings Plugin Nested rows Plugin Regression Issues that were created while adding new changes to the source code

Comments

@AMBudnik
Copy link
Contributor

AMBudnik commented May 8, 2020 •
edited

Description

When nestedRows are enabled we cannot call updateSettings. No further actions required.
The issue is now visible when we use updateSettings to pass nestedRows: false http://jsfiddle.net/nbo8Lf7z/

After fixing check #4716

Steps to reproduce

  1. Open the console to see the error

Demo

http://jsfiddle.net/vye5p2n3/ 8.0.0-beta2-rev1 (broken)
http://jsfiddle.net/vye5p2n3/1/ 8.0.0-beta1 (working well)
http://jsfiddle.net/vye5p2n3/2/ 7.4.2 (working well)

Your environment

  • Handsontable version: 8.0.0-beta2-rev1
  • Browser Name and version: Chrome 80
  • Operating System: macOS Catalina
@AMBudnik AMBudnik added bug Core: Update settings Plugin Nested rows Plugin Regression Issues that were created while adding new changes to the source code labels May 8, 2020
@AMBudnik AMBudnik mentioned this issue May 8, 2020
Closed
@aninde aninde mentioned this issue May 8, 2020
Closed
@wszymanski wszymanski assigned jansiegel and unassigned wszymanski May 12, 2020
@wszymanski
Copy link
Contributor

May be related to the #6678.

@AMBudnik
Copy link
Contributor Author

Might be a cause of the following misalignment of rows and false rowHeaders

http://jsfiddle.net/hLdjyamq/ (beta2)
Zrzut ekranu 2020-05-12 o 14 50 33

http://jsfiddle.net/L6mpz9wj/ (beta1)
Zrzut ekranu 2020-05-12 o 14 50 41

To be tested after fix.

jansiegel added a commit that referenced this issue May 14, 2020
@jansiegel
- Change the dataMap's 'spliceData' method to accept elements as rest…
0965bfd 
… arguments, accordingly to the native 'splice' method

- Rewrite the 'createRow' loop to update the index mappers before calling the 'beforeDataSplice' hook
- Modify the NestedRows cache to work on a pre-cached version of data (workaround for 'getSourceData' no longer returning references to data)
- Change the NestedRows' cache update to update with a pre-cached data, for the same reason as above.
#6860 #6855
@jansiegel jansiegel mentioned this issue May 14, 2020
Merged
1 task
jansiegel added a commit that referenced this issue May 21, 2020
@jansiegel @wszymanski
Update nestedRows and dataMap to work with 8.0-beta2 (#6889)
ed20102 
* - Change the dataMap's 'spliceData' method to accept elements as rest arguments, accordingly to the native 'splice' method
- Rewrite the 'createRow' loop to update the index mappers before calling the 'beforeDataSplice' hook
- Modify the NestedRows cache to work on a pre-cached version of data (workaround for 'getSourceData' no longer returning references to data)
- Change the NestedRows' cache update to update with a pre-cached data, for the same reason as above.
#6860 #6855

* Post CR changes. #6860

* - Remove the 'beforeDataSplice' hook docs (because of the discussion in #6889).
- Refactor some of the PR's code.
- Fix an issue with row creation.�
- Add a test case for 'updateSettings'.
 #6860

* - Post-CR changes
- Fix a problem with adding children to the nested structure, when the reference to the data has been broken
- Add tests to the NestedRows plugin
 #6860

* Just more specific tests #6860

Co-authored-by: Wojciech Szymanski <141330+wszymanski@users.noreply.github.com>
wszymanski added a commit that referenced this issue May 25, 2020
@wszymanski
Build revision 8 of the branch for tests. Fixes: #6916 (problem with …
945d49d 
…focus), #6917 (the ManualRowMove problems), problems with the NestedRows plugin (#6890, #6860, #6855, #6898)
@AMBudnik
Copy link
Contributor Author

Both issues : Main and rowHeaders: false are gone in 8.0.0.-beta2-rev8 http://jsfiddle.net/AMBudnik/tv96f1qa/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jansiegel jansiegel

Labels
bug Core: Update settings Plugin Nested rows Plugin Regression Issues that were created while adding new changes to the source code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wszymanski @jansiegel @AMBudnik