Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.0.0.-beta2-rev7] Wrong index for guideline when moves rows #6917

Closed
pnowak opened this issue May 21, 2020 · 2 comments
Closed

[8.0.0.-beta2-rev7] Wrong index for guideline when moves rows #6917

pnowak opened this issue May 21, 2020 · 2 comments
Assignees
@budnix
Labels
bug Hiding Plugin Moving Regression Issues that were created while adding new changes to the source code

Comments

@pnowak
Copy link
Contributor

pnowak commented May 21, 2020 •
edited

Description

If some rows are hidden and the other we move the guideline is always in there as if rows aren't hidden.

May-21-2020 14-47-50

In the 7.4.2 - https://jsfiddle.net/for879xy/
and in beta.1 - https://jsfiddle.net/xz289bLa/ - works as expected.

Steps to reproduce

  1. Move the first row, for example.

Demo

https://jsfiddle.net/trg8efuq/

Your environment

  • Handsontable version: 8.0.0.-beta2-rev7
  • Browser Name and version: Chrome 81
  • Operating System:
@pnowak pnowak added bug Hiding Plugin Moving Regression Issues that were created while adding new changes to the source code labels May 21, 2020
@AMBudnik
Copy link
Contributor

Case 2

Steps to reproduce

  1. Try to move A1 after A4

Result
A1 stays at its position, but hidden rows change.

issue

@budnix budnix self-assigned this May 22, 2020
@aninde aninde mentioned this issue May 22, 2020
Closed
budnix added a commit that referenced this issue May 22, 2020
@budnix
Add tests which checks UI components positioning
1f5a0ea 
Tests checks manual row move backlight and gridline element
positions in case when there are hidden some rows.

Issue: #6917
budnix added a commit that referenced this issue May 22, 2020
@budnix
Fix eslint complains
fa049d7 
Issue: #6917
@budnix budnix mentioned this issue May 22, 2020
Merged
6 tasks
budnix added a commit that referenced this issue May 22, 2020
@budnix
Add tests which checks UI components positioning
f0b79b5 
Tests checks manual column move backlight and gridline element
positions in case when there are hidden some columns.

Issue: #6917
@budnix budnix mentioned this issue May 22, 2020
Merged
6 tasks
budnix added a commit that referenced this issue May 22, 2020
@budnix
Remove test suites
5fb9cc5 
The removed tests was moved to separate file in the previous commit.

Issue: #6917
budnix added a commit that referenced this issue May 25, 2020
@budnix
Add tests which checks UI components positioning (#6925)
6fef637 
Tests checks manual column move backlight and gridline element
positions in case when there are hidden some columns.

Issue: #6917
budnix added a commit that referenced this issue May 25, 2020
@budnix
Fix manual row move misalignment
f55179f 
Add missing renderable<->visual indexes translations.

Add tests for manual row move backlight and gridline element
positions in a case when there are hidden some rows.

Issue: #6917
wszymanski added a commit that referenced this issue May 25, 2020
@wszymanski
Build revision 8 of the branch for tests. Fixes: #6916 (problem with …
945d49d 
…focus), #6917 (the ManualRowMove problems), problems with the NestedRows plugin (#6890, #6860, #6855, #6898)
@aninde
Copy link
Contributor

aninde commented May 26, 2020

This bug is fixed with 8.0.0.-beta2-rev8
https://jsfiddle.net/aninde/qb4g3ydr/
6917-rev8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@budnix budnix

Labels
bug Hiding Plugin Moving Regression Issues that were created while adding new changes to the source code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@budnix @pnowak @AMBudnik @aninde