[8.0.0.-beta2-rev1] Data from a merged cell is gone if its part is hidden - empty editor

[AMBudnik]

Description

Data from a merged cell is gone if its part is hidden. It is a regression from this issue #6871 - previously it was just a UI issue, in 8.0.0.-beta2 data is also gone from the editor.

Steps to reproduce

1. Go to https://jsfiddle.net/xc7uaohL/
2. Open editor for the merged cell - tthere should be B2 in the editor but it's blank
3. Type test in the merged cell - you can see test in the cell
4. Click the button below to log data in the console
5. Show columns
6. Unmerge cells - the old data is visible - B2, not test
7. Click the button below to log data in the console - you've changed C2, not B2

If you at this point click the button, you'll get B2 on its position and test on C2. Which also reflects if you unmerge the cells.

Previously

1. Go to https://jsfiddle.net/xc7uaohL/
2. Open editor for the merged cell - there's B2
3. Type test in the merged cell - you cannot see test in the cell
4. Click the button below to log data in the console
5. Show columns
6. Unmerge cells - the NEW data is visible - test
7. Click the button below to log data in the console - you've changed B2

Demo

https://jsfiddle.net/handsoncode/8ffpsqt6/ 7.4.2
https://jsfiddle.net/4brxm2df/2/ 8.0.0.-beta2 from commit 929b22c (last working)
https://jsfiddle.net/4brxm2df/3/ 8.0.0.-beta2 from commit 81020af (first broken)
https://jsfiddle.net/4brxm2df/4/ 8.0.0.-beta-rev4 (still broken)

Related issues

• [7.0.0] If the first part of the merged area is hidden the value does not show #6871

Your environment

• Handsontable version: 8.0.0.-beta2 from commit 81020af
• Browser Name and version: Chrome 80
• Operating System: macOS Catalina

[AMBudnik]

If we go to https://jsfiddle.net/xc7uaohL/ and click CTRL/CMD + Z to undo the C2 is back.

[wszymanski]

May be related to #6873.

[AMBudnik]

Case 2

Steps

1. Go to https://jsfiddle.net/AMBudnik/kz98cq1e/ 8.0.0-beta2-rev3
2. Select A1
3. Hold CMD/CTRL and click E2

Result
You selected A1:E3 instead of A1:E2.

The issue's also replicable in 8.0.0-beta2-rev10 https://jsfiddle.net/AMBudnik/k6robep7/1/

[wojciechczerniak]

Case 2

Steps

1. Go to https://jsfiddle.net/AMBudnik/kz98cq1e/ 8.0.0-beta2-rev3
2. Select A1
3. Hold CMD/CTRL and click E2

Result
You selected A1:E3 instead of A1:E2.

The issue's also replicable in 8.0.0-beta2-rev10 https://jsfiddle.net/AMBudnik/k6robep7/1/

Exactly how it supposed to. This is the desired behavior. Check XL and GS.

[AMBudnik]

@wojciechczerniak is right. Works the same way in Google Sheets 🤔 but I did not change my mind when it comes to UX this looks odd. Nevertheless, we can check if it works the same way after we get some fresh new commits 👍

[AMBudnik]

@wojciechczerniak what about this, let's call it case 3

Case moved to #6978

Steps
1. Select both columns
2. Use Merge cells from the context menu
3. Use CTRL/CMD + Z to undo

Result

I would expect to get the same result as we get (cause we do not support undo-redo for hiding/showing) but with header A highlighted (not all of them).

Here's Google Sheets reproduction for comparison

[wojciechczerniak]

True. Only A header should be selected. Is this a regression?

For undo/redo hidding column we should have a separate issue. This is out of scope

[AMBudnik]

True. Only A header should be selected. Is this a regression?

Broken in 8.0.0-beta2-rev10 https://jsfiddle.net/AMBudnik/2t5sdgoz/ as well as 7.4.2 (and 6.2.2) https://jsfiddle.net/AMBudnik/bp0xrv1y/ - not a regression. I'll move it to a separate issue.

[wszymanski]

When we merge cells, the first of which is hidden, we don't see the content and we have an empty, merged cell. http://jsfiddle.net/aninde/ehs1obzq/1 8.0.0-beta2-rev10. When the first row ceases to be hidden A2 is displayed on the merged cells.

Probably related to the Handsontable 7+. Please check if extra information should be added to the #6871.

[AMBudnik]

@wszymanski @aninde

Probably related to the Handsontable 7+. Please check if extra information should be added to the #6871.

all - 8.0.0.beta2-rev6 http://jsfiddle.net/AMBudnik/mvntg5pb/

8.0.0.beta2-rev7 - rev10 http://jsfiddle.net/AMBudnik/2yq6zj91/

We may say that it never displayed the value and before rev7 it was broken even worse.

EDIT: Works the same for rev11 http://jsfiddle.net/AMBudnik/43poemx6/

[aninde]

@AMBudnik you're right, this issue (#6872 (comment)) has already been partially reported here #6224 (comment).

[AMBudnik]

The main issue is solved in 8.0.0-beta2-rev11 https://jsfiddle.net/AMBudnik/ctjm0zhv/ it works the same way as it worked before the regression.

As case 2 is intended, case 3 is moved and the case with

When we merge cells, the first of which is hidden, we don't see the content

is reported in other issues we can close this topic.

Thanks guys!