Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0.0.-beta2-rev1] Merged area is not highlighted if a part of it is hidden #6873

Closed
AMBudnik opened this issue May 13, 2020 · 4 comments
Closed
Assignees
Labels
bug Core: Selection Plugin Merge cells Plugin Regression Issues that were created while adding new changes to the source code

Comments

@AMBudnik
Copy link
Contributor

Description

Merged area is not highlighted if a part of it is hidden.

Steps to reproduce

  1. Go to https://jsfiddle.net/h8t7wmdr/
  2. Select columns A-C

Result
The merged area is not highlighted
Zrzut ekranu 2020-05-13 o 10 10 42

Expected result
Zrzut ekranu 2020-05-13 o 10 10 11

Demo

https://jsfiddle.net/h8t7wmdr/ 8.0.0.-beta2-rev3 (broken)
https://jsfiddle.net/235snLvr/ 8.0.0.-beta2-rev1 (broken)
https://jsfiddle.net/8uho2f3L/ 8.0.0-beta1 (works well)
https://jsfiddle.net/8uho2f3L/1/ 7.4.2 (works well)

Your environment

  • Handsontable version: 8.0.0.-beta2-rev1
  • Browser Name and version: Chrome 80
  • Operating System: macOS Catalina
@AMBudnik AMBudnik added bug Merge cells Plugin Core: Selection Plugin Regression Issues that were created while adding new changes to the source code labels May 13, 2020
@AMBudnik
Copy link
Contributor Author

Works the same if we hide right part (without visible data) https://jsfiddle.net/7a3cq2mt/
Zrzut ekranu 2020-05-13 o 10 24 06

@AMBudnik
Copy link
Contributor Author

AMBudnik commented Jun 4, 2020

Case 2

Context menu for merged cell sows different option in context menu
https://jsfiddle.net/AMBudnik/ktqogzwb/ 8.0.0.-beta2-rev7 - 8.0.0.-beta2-rev10
https://jsfiddle.net/AMBudnik/dbcqm7vk/1/ 7.4.2 - 8.0.0-beta2-rev6

Steps

  1. Go to https://jsfiddle.net/AMBudnik/ktqogzwb/
  2. Open context menu for A header

Result
In versions from 8.0.0.-beta2-rev7 to 8.0.0.-beta2-rev10 we get Merge cells option
Zrzut ekranu 2020-06-4 o 07 42 51

Steps

  1. Go to https://jsfiddle.net/AMBudnik/dbcqm7vk/1/
  2. Open context menu for A header

Result
In version from 7.4.2 to 8.0.0.-beta2-rev6 we get Unmerge cells
Zrzut ekranu 2020-06-4 o 07 45 00

@aninde
Copy link
Contributor

aninde commented Jun 4, 2020

A list of known bugs that can be related:

@AMBudnik
Copy link
Contributor Author

AMBudnik commented Jun 9, 2020

Main case solved with 8.0.0-beta2-rev13 https://jsfiddle.net/AMBudnik/8fjdnq0p/
The case 2 solved with 8.0.0-beta2-rev13https://jsfiddle.net/AMBudnik/js1dwt7y/

Well done!

@AMBudnik AMBudnik closed this as completed Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Core: Selection Plugin Merge cells Plugin Regression Issues that were created while adding new changes to the source code
Projects
None yet
Development

No branches or pull requests

3 participants