[8.0.0.-beta2-rev1] nestedHeaders and hiddenColumns don't work together #6879

pnowak · 2020-05-13T12:50:59Z

Description

If we set both plugins, not all column headers are displayed.

7.4.2 - https://jsfiddle.net/53dmngb7/1/

8.0.0. beta-1 - https://jsfiddle.net/7a4obtck/

Demo

https://jsfiddle.net/ep069nqy/1/

Your environment

Handsontable version: 8.0.0. beta-2-rev3
Browser Name and version: Chrome 80
Operating System: macOS Mojave

AMBudnik · 2020-05-26T11:57:52Z

This was broken in 8.0.0-beta2-rev1 https://jsfiddle.net/AMBudnik/dcohnzvu/

Here's a second case to check.

Steps to reproduce

Click Hide columns
Scroll right to check the state of nestedHeaders.
Click Show columns

Result
There are nestedHeaders missing when we hide columns with the button.

8.0.0-beta2-rev1 - 8.0.0-beta2-rev8 hiding issue

after the selection of the C header.

Demos

https://jsfiddle.net/AMBudnik/5c82p1xL/ 7.4.2 (works well)
https://jsfiddle.net/AMBudnik/0vfL8tm3/ (works well)
https://jsfiddle.net/AMBudnik/6cawp8n4/ 8.0.0-beta2-rev1 (broken)
https://jsfiddle.net/AMBudnik/xa7ckLyh/ 8.0.0-beta2-rev8 (broken)

Inform forum, and forum and Zen 25290, Gro 32275, Zen 26217, forum, and forum

aninde · 2020-07-06T12:03:00Z

Still broken on latest rev 8.0.-beta2-rev18 https://jsfiddle.net/ep069nqy/1/

AMBudnik · 2020-08-04T08:48:57Z

We should also test cases reported here #7160 after fixing this issue.

AMBudnik · 2020-08-28T13:29:58Z

stable v8.0.0 https://jsfiddle.net/AMBudnik/z87h1v2g/ looks like the mentioned revision

m4m4m4 · 2020-09-23T09:11:20Z

Any ETA on this? Would love to upgrade to v.8 but this affects us heavily

AMBudnik · 2020-09-29T11:08:21Z

Hi @m4m4m4 the issue is currently in development

budnix · 2020-10-05T08:25:47Z

I add so that it does not disappear a PoC (unfinished) https://github.com/handsontable/handsontable/tree/feature/issue-6839

Issue: #6879

Move methods about creating IndexMaps from Core to IndexMapper. Implement "mapNamesIgnoreList" option for index changes listener. Add tests for NestedHeaders plugin cooperation with hiding columns. Issue: #6879

Issue: #6879

The module provides the ability to observe the changes that happened in the index map values during the code running. Currently, only the "hiding" index map types can be observable. The commit covers all module implementation with unit tests. The "crossHidingColumns" meta property is moved from the tree data to the source settings. Thanks to this, building a tree structure from scratch (it happens after the "updateSettings" call) does not cause metadata loss. To the "hideColumn" and "showColumn" tree modifiers, there is added a logic that ignores the action when the collapsible node is detected. This allows postponing the bug fix related to collapsible headers to the next phase. Issue: #6879

Add more tests for the NestedHeaders plugin cooperation with hidden columns (using hidden map). Add missing tests for new method added to the NestedHeaders' state manager and add integration tests for the ChangesObservable module cooperation with IndexMapper object. Issue: #6879

Issue: #6879

That changes fixes the headers selection when the NestedHeaders plugin is enabled. When the plugin is enabled it blocks the native columns selection within the Selection module. The plugin is responsible for column selection. Depends on what header level is clicked and how the tree structure looks like the plugin based on its state selects the correct columns. To achieve that the new hook "beforeHighlightingRowHeader" is added. The hook allows control the visual column index under the TH element will be modified. Issue: #6879

Issue: #6879

To decrease the overall memory footprint the index mapper instances are nulled. Additionally, the redundant unit test is removed. Issue: #6879

Issue: #6879

The change is compatible with how the build-in selection works. When no table header is selected it's possible to select the header using RMB. Otherwise, it's not possible. Issue: #6879

The commit fixes an issue where hiding columns causes nested headers to glitch. Several modules had to be extended with new functionalities to get the state where nested headers work correctly. * New modifiers are added to the nodeModifier module. The nested headers tree structure can be manipulated by the new "hideColumn" and "showColumn" modifiers. Within the PR, the modifiers are split into separate files for better maintainability. * The "matrixGenerator" module is rewritten to support new tree metadata props (crossHiddenColumns). * For the IndexMapper module, the "changesObservable" module is added. The module allows observing the index changes changed during HoT runtime. Currently, only the "hiding" map is supported. Thanks to that the tree does not have to build from scratch but can be modified on index change. * To the IndexMapper, the new methods are added. The methods complement the IndexMapper API. So from the Handsontable instance, there is a possibility to create index maps and use them to manipulate rows/columns behavior. For instance: `hot.rowIndexMapper.createAndRegisterIndexMap`. * The header highlighting process is fixed. From, now on only the headers closest to the dataset are highlighted (grey). An only active highlight (blue) is applied to all header layers. It's worth noticing that the PR is focused on fixing the cooperation of the NestedHeaders plugin and the HidingColumns (and hiding map in general). The collapsible headers will be fixed in separate PR. Moreover, the PR changes how the selection of the nested headers is held. Previously no matter what header level was clicked the selection coordinates started from -1. The list of backward-compatible changes: * New `createAndRegisterIndexMap()` method for IndexMapper; * New `createChangesObserver()` method for IndexMapper; * New `unregisterAll()` method for IndexMapper; * New `beforeHighlightingColumnHeader` and `beforeHighlightingRowHeader` hooks. Issue: #6879

aninde · 2021-05-05T13:10:46Z

This issue will be fixed by the v.8.4.0

Demo: https://jsfiddle.net/t01naufr/

AMBudnik · 2021-05-11T12:03:51Z

@aninde so much better! That's a relief to see this issue fixed.

@m4m4m4 I'm sure you'll benefit from this fix

pnowak added bug Hiding Plugin Nested headers Plugin Regression Issues that were created while adding new changes to the source code labels May 13, 2020

pnowak assigned wszymanski May 13, 2020

aninde mentioned this issue May 13, 2020

[8.0.0-beta2] List of found bugs handsontable/quality#51

Closed

AMBudnik mentioned this issue May 14, 2020

Bug: Nested headers and hidden columns highlight the next column #6881

Closed

AMBudnik changed the title ~~[8.0.0.-beta2-rev3] nestedHeaders and hiddenColumns don't work together~~ [8.0.0.-beta2-rev1] nestedHeaders and hiddenColumns don't work together May 26, 2020

This was referenced Jul 1, 2020

Hide columns marked as collapsible #6839

Closed

with hidden column , collapsibleColumns don't work well #6641

Closed

aninde added the Focus / blur Issues related to focus label Jul 6, 2020

AMBudnik mentioned this issue Aug 4, 2020

[8.0.0-beta.2] Script error when using hiddenColumns with nestedHeaders #7160

Closed

wojciechczerniak modified the milestones: August 2020, September 2020 Aug 4, 2020

wszymanski removed their assignment Sep 9, 2020

jansiegel self-assigned this Sep 28, 2020

jansiegel added the Status: To be discussed Plugin label Oct 5, 2020

wojciechczerniak unassigned jansiegel Oct 6, 2020

budnix added a commit that referenced this issue Mar 18, 2021

Regenerate package-lock file

a47c413

Issue: #6879

budnix added a commit that referenced this issue Mar 18, 2021

Fix E2E tests

8f2638c

Issue: #6879

budnix added a commit that referenced this issue Mar 22, 2021

Regenerate package-json file (fix snyk complains)

c59d19d

Issue: #6879

budnix added a commit that referenced this issue Mar 25, 2021

Cover new IndexMapper methods with tests

bb5ee4f

Issue: #6879

budnix added a commit that referenced this issue Mar 25, 2021

Add tests for ChangesObservable module

e5f777c

Issue: #6879

budnix added a commit that referenced this issue Apr 6, 2021

Fix headers desync after updateSettings call

c99047a

Issue: #6879

budnix added a commit that referenced this issue Apr 7, 2021

Add tests for nested headers cooperation with showing columns actions

311e73e

Issue: #6879

budnix added a commit that referenced this issue Apr 14, 2021

Add tests for new hooks and code clean-up

4750e68

Issue: #6879

budnix added a commit that referenced this issue Apr 15, 2021

Restore the original behavior of the Selection class

f3549d7

Issue: #6879

budnix linked a pull request Apr 15, 2021 that will close this issue

Allow to hide columns that have nested headers #7528

Merged

16 tasks

budnix added a commit that referenced this issue Apr 15, 2021

Add tests for selection with cooperation with hiding/showing columns

aee44ca

Issue: #6879

budnix added a commit that referenced this issue Apr 15, 2021

Update TS definition for CollapsibleColumns and NestedHeaders plugins

de109e8

Issue: #6879

budnix added a commit that referenced this issue Apr 16, 2021

Fix typo

f9e036b

Issue: #6879

budnix added a commit that referenced this issue Apr 16, 2021

Fix a bug where the selection changed after using RMB

a48951e

Issue: #6879

budnix added a commit that referenced this issue Apr 20, 2021

Revert index mapper nulling after HoT destroying

2e2f8ad

To decrease the overall memory footprint the index mapper instances are nulled. Additionally, the redundant unit test is removed. Issue: #6879

budnix added a commit that referenced this issue Apr 20, 2021

Add support for selection using the SHIFT key

420da76

Issue: #6879

budnix added a commit that referenced this issue Apr 20, 2021

Add more tests for selection modified by the SHIFT key

6634257

Issue: #6879

budnix added a commit that referenced this issue Apr 20, 2021

Allow select column header using RMB

3bdd576

The change is compatible with how the build-in selection works. When no table header is selected it's possible to select the header using RMB. Otherwise, it's not possible. Issue: #6879

AMBudnik mentioned this issue May 11, 2021

What’s New in Handsontable 8.4.0 #7998

Closed

AMBudnik added Status: Released and removed Status: To be discussed Plugin labels May 11, 2021

AMBudnik closed this as completed May 12, 2021

AMBudnik mentioned this issue Jun 6, 2022

Table Headers renders incorrectly. Nested Headers / Columns / Manual Column / Hidden Columns #9565

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[8.0.0.-beta2-rev1] nestedHeaders and hiddenColumns don't work together #6879

[8.0.0.-beta2-rev1] nestedHeaders and hiddenColumns don't work together #6879

pnowak commented May 13, 2020

AMBudnik commented May 26, 2020 •

edited

Loading

aninde commented Jul 6, 2020

AMBudnik commented Aug 4, 2020

AMBudnik commented Aug 28, 2020

m4m4m4 commented Sep 23, 2020

AMBudnik commented Sep 29, 2020

budnix commented Oct 5, 2020

aninde commented May 5, 2021

AMBudnik commented May 11, 2021 •

edited

Loading

[8.0.0.-beta2-rev1] nestedHeaders and hiddenColumns don't work together #6879

[8.0.0.-beta2-rev1] nestedHeaders and hiddenColumns don't work together #6879

Comments

pnowak commented May 13, 2020

Description

Demo

Your environment

AMBudnik commented May 26, 2020 • edited Loading

Steps to reproduce

Demos

aninde commented Jul 6, 2020

AMBudnik commented Aug 4, 2020

AMBudnik commented Aug 28, 2020

m4m4m4 commented Sep 23, 2020

AMBudnik commented Sep 29, 2020

budnix commented Oct 5, 2020

aninde commented May 5, 2021

AMBudnik commented May 11, 2021 • edited Loading

AMBudnik commented May 26, 2020 •

edited

Loading

AMBudnik commented May 11, 2021 •

edited

Loading