Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.0.0-beta2-rev17] Click on the corner doesn't select headers when rows are trimmed #7063

Closed
budnix opened this issue Jun 30, 2020 · 2 comments
Closed

[8.0.0-beta2-rev17] Click on the corner doesn't select headers when rows are trimmed #7063

budnix opened this issue Jun 30, 2020 · 2 comments
Assignees
@jansiegel
Labels
Core: Selection Plugin enhancement Guess: A few hours

Comments

@budnix
Copy link
Member

budnix commented Jun 30, 2020 •
edited

Description

When I click on the corner when there are some cells then the row and column headers are highlighted. However when the rows or columns are trimmed then nothing happens. it would be nice if headers were highlighted in this case.

This is related to how the selectAll method works (or doesn't work).

Steps to reproduce

  1. Go to https://jsfiddle.net/budnix/056f1mxa/;
  2. Trim all rows using Filters feature;
  3. Click on the corner;
  4. In a result nothing happens;

Demo

https://jsfiddle.net/budnix/056f1mxa/

Your environment

  • Handsontable version: ~8.0.0-beta.2-rev17
  • Browser Name and version: any
  • Operating System: any
@budnix budnix mentioned this issue Jun 30, 2020
Merged
6 tasks
@wszymanski wszymanski mentioned this issue Jul 1, 2020
Closed
@aninde
Copy link
Contributor

aninde commented Jul 1, 2020

Related to #7061

@wojciechczerniak wojciechczerniak mentioned this issue Jul 1, 2020
Closed
204 tasks
@jansiegel jansiegel self-assigned this Jul 1, 2020
jansiegel added a commit that referenced this issue Jul 3, 2020
@jansiegel
- Make calling the 'selectAll' method or clicking on the corner heade…
6afe72b 
…r select the column headers even if all the rows are trimmed

- Fix some issues with the 'toBeMatchToSelectionPattern' matcher
#7063
@jansiegel jansiegel mentioned this issue Jul 3, 2020
Merged
6 tasks
jansiegel added a commit that referenced this issue Jul 6, 2020
@jansiegel
- Make calling the 'selectAll' method or clicking on the corner heade…
21813d4 
…r select the column headers even if all the rows are trimmed (#7071)

- Fix some issues with the 'toBeMatchToSelectionPattern' matcher
#7063
budnix added a commit that referenced this issue Jul 7, 2020
@budnix
Adjust the context menu items disability
387d2fd 
This PR adjusts disability state of the context menu items responsible
for adding row and columns. Menu options such as "Insert row above" and
"Insert row below" are always disabled for context menu triggered by the
column header click (no matter if there are rendered cells, trimmed or
hidden). The same applies to the context menu triggered by the row
header click. Also, the menu items are unified how they work for menu
triggered by corner click. From now on, options "Insert row below" and
"Insert column on the right" are always enabled. After the clicking the
operation, the new index is created right after the corner position.

Issue: #7063
budnix added a commit that referenced this issue Jul 7, 2020
@budnix
Adjust the context menu items disability
24dfec5 
This PR adjusts disability state of the context menu items responsible
for adding row and columns. Menu options such as "Insert row above" and
"Insert row below" are always disabled for context menu triggered by the
column header click (no matter if there are rendered cells, trimmed or
hidden). The same applies to the context menu triggered by the row
header click. Also, the menu items are unified how they work for menu
triggered by corner click. From now on, options "Insert row below" and
"Insert column on the right" are always enabled. After the clicking the
operation, the new index is created right after the corner position.

Issue: #7063
@budnix budnix mentioned this issue Jul 7, 2020
Merged
48 tasks
@aninde aninde changed the title Click on the corner doesn't select headers when rows are trimmed [8.0.0-beta2-rev17] Click on the corner doesn't select headers when rows are trimmed Jul 7, 2020
@aninde
Copy link
Contributor

aninde commented Jul 7, 2020

This issue is solved by 8.0.0-beta2-rev19 https://jsfiddle.net/aninde/fjxc4w35/
fixed

@aninde aninde closed this as completed Jul 7, 2020
@aninde aninde mentioned this issue Jul 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jansiegel jansiegel

Labels
Core: Selection Plugin enhancement Guess: A few hours
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@budnix @jansiegel @aninde