Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.0.0+] If the first column is hidden HOME key moves the selection to a wrong index and disables the ability to key navigate #7454

Closed
AMBudnik opened this issue Dec 31, 2020 · 2 comments
Closed

[8.0.0+] If the first column is hidden HOME key moves the selection to a wrong index and disables the ability to key navigate #7454

AMBudnik opened this issue Dec 31, 2020 · 2 comments
Assignees
@wszymanski
Labels
bug Core: Selection Plugin Hiding Plugin Regression Issues that were created while adding new changes to the source code Status: Released
Milestone
February 2021

Comments

@AMBudnik
Copy link
Contributor

AMBudnik commented Dec 31, 2020 •
edited by wszymanski
Loading

Description

If the first column is hidden HOME key

  • moves the selection to a wrong index
  • disables the ability to key navigate

Steps to reproduce

  1. Click D2 cell
  2. Click HOME
  3. Try to navigate right with the arrow > key

7.4.2 and older
742-ok

8.0.0 and newer
800-notok

Demo

7.4.2 - https://jsfiddle.net/handsoncode/bhxac9rz - moves the selection to the first visible cell
8.0.0 - https://jsfiddle.net/handsoncode/4nska6hv - moves to A column which is hidden

Your environment

  • Handsontable version: 8+
  • Browser Name and version: Chrome 87
  • Operating System: Windows 10

Inform forum
@AMBudnik AMBudnik added bug Hiding Plugin Core: Selection Plugin Regression Issues that were created while adding new changes to the source code labels Dec 31, 2020
@aninde aninde mentioned this issue Jan 7, 2021
Closed
@wojciechczerniak wojciechczerniak added this to the February 2021 milestone Jan 25, 2021
@wszymanski wszymanski self-assigned this Feb 4, 2021
wszymanski added a commit that referenced this issue Feb 8, 2021
@wszymanski
Fixed bugs in navigation by HOME and END keys when there are some hid…
9b8f129 
…den rows/columns & wrote tests #7454
wszymanski added a commit that referenced this issue Feb 8, 2021
@wszymanski
Added entry to the CHANGELOG #7454
4b0185a
@wszymanski wszymanski mentioned this issue Feb 8, 2021
Merged
6 tasks
wszymanski added a commit that referenced this issue Feb 12, 2021
@wszymanski
Fixed bugs in navigation by HOME and END keys when there are some hid…
13e6313 
…den rows/columns (#7519)

* Fixed bugs in navigation by HOME and END keys when there are some hidden rows/columns & wrote tests #7454

* Added entry to the CHANGELOG #7454
@aninde aninde mentioned this issue Feb 24, 2021
Closed
27 tasks
@aninde
Copy link
Contributor

aninde commented Mar 10, 2021

This issue has been fixed by v8.3.2. Good job :)

macOS doesn't have HOME and END keys, so I've checked it with macOS's equivalent of them, i.e. Fn+ Left Arrow and Fn+ Right Arrow.

Tested on
macOS 11.2.2 (20D80) - Chrome 88.0.4324.192, Safari 14.0.3 (16610.4.3.1.4), Firefox 86.0 , Edge 89.0.774.48, Opera 74.0.3911.203
Windows 10 - Chrome 88.0.4324.192 , Edge 89.0.774.48, IE 11, Firefox 86.0.

@AMBudnik AMBudnik mentioned this issue Mar 16, 2021
Closed
@AMBudnik
Copy link
Contributor Author

Thank you for solving! I'm closing this issue as fixed in v8.3.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wszymanski wszymanski

Labels
bug Core: Selection Plugin Hiding Plugin Regression Issues that were created while adding new changes to the source code Status: Released
Projects
None yet
Milestone
February 2021
Development

No branches or pull requests
4 participants
@wszymanski @wojciechczerniak @AMBudnik @aninde