Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Move "An advanced example" from the HotColumn component page to another page #9911

Closed
warpech opened this issue Sep 15, 2022 · 0 comments · Fixed by #9999
Closed

Docs: Move "An advanced example" from the HotColumn component page to another page #9911

warpech opened this issue Sep 15, 2022 · 0 comments · Fixed by #9999
Assignees
Labels
Docs: Content Issues related to Handsontable's documentation content

Comments

@warpech
Copy link
Member

warpech commented Sep 15, 2022

Description

At the bottom of the HotColumn component page (React docs), there is "An advanced example", which does not really fit this page well. It shows:

  1. the use of HotColumn component (nothing unique compared to the examples above it)
  2. a custom React component editor, which is also a custom React component renderer. This is unique, and not presented elsewhere in the docs. It better fits the "Cell editor" and "Cell renderer" pages
  3. the editor and renderer mentioned above, uniquely use Redux, not the internal lifecycle of Handsontable, to manage the state. This is unique, and goes much deeper than the page "Integration with Redux". However, I am not even sure if we should present such usage. It goes against every other page in the docs.

Links

@warpech warpech added the Docs: Content Issues related to Handsontable's documentation content label Sep 15, 2022
@kirszenbaum kirszenbaum self-assigned this Oct 6, 2022
@kirszenbaum kirszenbaum linked a pull request Oct 6, 2022 that will close this issue
kirszenbaum pushed a commit that referenced this issue Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs: Content Issues related to Handsontable's documentation content
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants