New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix "TypeError: Converting circular structure to JSON" when passing hyperformulaInstance
to hotSettings
#10186
Conversation
hyperformulaInstance
hyperformulaInstance
to hotSettings
Thank you very much for creating the pull request, signing CLA, and adding the test scenario. |
be12939
to
d65dda6
Compare
f32961d
to
e38035e
Compare
e38035e
to
8f32285
Compare
8f32285
to
728225a
Compare
728225a
to
53f981a
Compare
da570db
to
115af18
Compare
why not merge? I have the same problem. cc: @kirszenbaum @AMBudnik @adrianszymanski89
|
…hyperformulaInstance`
115af18
to
caa1017
Compare
@tonextone Can I ask you to add a changelog file? You can generate that by running |
@budnix Thank you for the follow-up. I just added a changelog entry. ( It's my first time, so I'm not sure if it's perfect. ) |
Thank you again for your contribution @tonextone |
Context
Fixes the issue #8728 (comment) .
For
JSON.stringify()
is used to comparehotSettings
(current ⇔ new) ,any circular structure ( like
hyperformulaInstance
) withinhotSettings
causes this: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Errors/Cyclic_object_value
How has this been tested?
Added a test case.
Types of changes
Related issue(s):
Affected project(s):
handsontable
@handsontable/angular
@handsontable/react
@handsontable/vue
@handsontable/vue3
Checklist: