Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makes the selection handlers always on top of the table #10447

Merged
merged 4 commits into from Jul 31, 2023
Merged

Makes the selection handlers always on top of the table #10447

merged 4 commits into from Jul 31, 2023

Conversation

budnix
Copy link
Member

@budnix budnix commented Jul 14, 2023

Context

The PR fixes a bug where the selection handlers (mobile) disappear below the headers when more then 1 column was selected.

How has this been tested?

I tested the changes locally, and I cover the fix with updated E2E tests;

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Related issue(s):

  1. fixes https://github.com/handsontable/dev-handsontable/issues/884

Affected project(s):

  • handsontable

Checklist:

@budnix budnix self-assigned this Jul 14, 2023
@budnix budnix marked this pull request as ready for review July 14, 2023 08:52
@budnix budnix requested a review from jansiegel July 17, 2023 19:22
@budnix budnix merged commit e8dd43f into develop Jul 31, 2023
21 checks passed
@budnix budnix deleted the feature/dev-issue-884 branch July 31, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jansiegel jansiegel jansiegel approved these changes

Assignees

@budnix budnix

Labels
Status: Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@budnix @jansiegel @AMBudnik