Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node to the latest LTS version #10468

Merged
merged 17 commits into from
Aug 28, 2023
Merged

Update Node to the latest LTS version #10468

merged 17 commits into from
Aug 28, 2023

Conversation

budnix
Copy link
Member

@budnix budnix commented Aug 17, 2023

Context

The PR updates the monorepo to work with Node 20 (upcoming LTS).

Changes:

  • Update all GitHub workflow flows to use Node 20;
  • Remove all Node experimental flags;
  • Fix eslint complaints about import orders;
  • Update Docs about custom builds (update required Node version);
  • Add export NODE_OPTIONS=--openssl-legacy-provider; Node option for all packages that use old Webpack 4 underneath. Otherwise, the Webpack throws an error after trying to build something (the latest supported Node is 16);
  • Remove Angular Next from examples;
  • Fix configuration that causes the Angular wrapper tests to fail;

How has this been tested?

  • I tested the changes locally using Node 20.5.1 (npm 9.8.0);
  • I triggered GH code examples with success (run);
  • I triggered Docs staging deployment using Node 20, and the flow ended with success (run);
  • I triggered flow that checks the monorepo packages in different OSs with success (run);
  • I triggered pre-releases GH flow with success (run);

Types of changes

  • New feature or improvement (non-breaking change which adds functionality)

Related issue(s):

  1. fixes https://github.com/handsontable/dev-handsontable/issues/1402

Affected project(s):

  • handsontable
  • @handsontable/angular
  • @handsontable/react
  • @handsontable/vue
  • @handsontable/vue3

Checklist:

@budnix budnix self-assigned this Aug 17, 2023
@github-actions
Copy link

github-actions bot commented Aug 17, 2023

Launch the local version of documentation by running:

npm run docs:review 054ea8f5ed232acaeaf102ecb00d5bdfe0c1f37c

@budnix budnix marked this pull request as ready for review August 18, 2023 08:44
@budnix budnix requested a review from jansiegel August 18, 2023 09:09
@budnix budnix merged commit 9568df7 into develop Aug 28, 2023
22 checks passed
@budnix budnix deleted the feature/dev-issue-1402 branch August 28, 2023 08:39
budnix added a commit that referenced this pull request Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants