Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backlight position of the manual row/column move plugins #10475

Merged
merged 11 commits into from Aug 28, 2023

Conversation

budnix
Copy link
Member

@budnix budnix commented Aug 22, 2023

Context

The PR fixes the backlight element position of the ManualColumnMove and ManualRowMove plugins.

Changes

Fix an issue where the backlight was misaligned when the mouse drag position began from the middle of the header.

Before

Kapture 2023-08-24 at 11 48 05

After

Kapture 2023-08-24 at 11 50 42

Fix an issue where the backlight was misaligned when the table was initialized without defining size (the window is a scrollable element). The bug existed only in the ManualRowMove plugin.

Before

Kapture 2023-08-24 at 11 54 51

After

Kapture 2023-08-24 at 11 55 26

and the last change is removing code for unsupported browsers (diff1, diff2)

How has this been tested?

I tested the changes locally and I covered the fixes with new E2E tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Related issue(s):

  1. fixes https://github.com/handsontable/dev-handsontable/issues/97
  2. fixes https://github.com/handsontable/dev-handsontable/issues/99

Affected project(s):

  • handsontable

Checklist:

@budnix budnix self-assigned this Aug 22, 2023
@budnix budnix marked this pull request as ready for review August 24, 2023 09:59
@budnix budnix requested a review from wszymanski August 24, 2023 10:01
@github-actions
Copy link

Launch the local version of documentation by running:

npm run docs:review f93cec3b40873c072b0fe492f7e58c0bf97c2525

@budnix budnix merged commit c8688e9 into develop Aug 28, 2023
21 checks passed
@budnix budnix deleted the feature/dev-issue-97 branch August 28, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants