Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing 'updateData' ChangeSource type #10488

Merged
merged 4 commits into from Sep 4, 2023
Merged

Add missing 'updateData' ChangeSource type #10488

merged 4 commits into from Sep 4, 2023

Conversation

budnix
Copy link
Member

@budnix budnix commented Aug 31, 2023 •
edited

Context

The PR adds the missing 'updateData' type to the ChangeSource type.

How has this been tested?

I tested the change locally and updated the types test.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Related issue(s):

  1. fixes https://github.com/handsontable/dev-handsontable/issues/1397

Affected project(s):

  • handsontable

Checklist:

@budnix budnix self-assigned this Aug 31, 2023
@budnix budnix marked this pull request as ready for review August 31, 2023 12:37
@budnix budnix requested a review from wszymanski August 31, 2023 12:37
wszymanski
wszymanski approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@wszymanski wszymanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea to test the callback 👍

@budnix budnix merged commit f29c16e into develop Sep 4, 2023
20 checks passed
@budnix budnix deleted the feature/dev-issue-1397 branch September 4, 2023 09:38
@adrianszymanski89 adrianszymanski89 mentioned this pull request Sep 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wszymanski wszymanski wszymanski approved these changes

Assignees

@budnix budnix

Labels
Status: Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@budnix @wszymanski @AMBudnik