Improve performance in cases when table is hiding #10490
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The PR improves the component performance in cases when the table is mounted in places where the container element is hidden and shown alternately. For example in Tabs.
I found that the table recalculated its sizes after it detects its root element is hidden (
display: "none"
) - unnecessarily, I think. The recalculation is time-consuming, so In this PR, I changed the logic to do a recalculation thing only when the element is shown. Thanks to that, there is no lag between switching the tabs as the Handsontable after showing the tab again uses the cached values.How has this been tested?
I tested the changes locally, and I covered the change with new tests.
Types of changes
Related issue(s):
Affected project(s):
handsontable
Checklist: