Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TS definition for Filters plugin and Core methods #10494

Merged
merged 4 commits into from Sep 4, 2023

Conversation

budnix
Copy link
Member

@budnix budnix commented Sep 1, 2023

Context

The PR updates the wrong TS definition for the Filters plugin methods and the definition for returned values of the colToProp method. The PR moves tests from general files to individual ones in the plugins directory.

How has this been tested?

I tested the changes locally and I covered the fix with types tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Related issue(s):

  1. fixes https://github.com/handsontable/dev-handsontable/issues/446

Affected project(s):

  • handsontable

Checklist:

@budnix budnix self-assigned this Sep 1, 2023
@budnix budnix marked this pull request as ready for review September 1, 2023 10:25
@budnix budnix merged commit c97ac1a into develop Sep 4, 2023
21 checks passed
@budnix budnix deleted the feature/dev-issue-446 branch September 4, 2023 10:34
@AMBudnik AMBudnik mentioned this pull request Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants