Fix a bug where pressing a Ctrl/Cmd does not trigger non-contiguous selection #10502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
budnix
commented
Sep 6, 2023
| @@ -4713,11 +4713,8 @@ export default function Core(rootElement, userSettings, rootInstanceSymbol = fal | |||
| }; | |||
|
|
|||
| const shortcutManager = createShortcutManager({ | |||
| handleEvent(event) { | |||
| const isListening = instance.isListening(); | |||
| const isKeyboardEventWithKey = event?.key !== void 0; | |||
There was a problem hiding this comment.
@wszymanski I removed this line as I felt it's here only for tests, not for real user use cases. The event object is always passed as it is directly passed from the native event, and looking through the MDN and typing the key property seems to have always some value.
There was a problem hiding this comment.
I can't find a reason why it's there.
|
Launch the local version of documentation by running: npm run docs:review 77b32da2be2d27756f1c0e329dea01ae6ff728a9 |
wszymanski
approved these changes
Sep 13, 2023
| @@ -4713,11 +4713,8 @@ export default function Core(rootElement, userSettings, rootInstanceSymbol = fal | |||
| }; | |||
|
|
|||
| const shortcutManager = createShortcutManager({ | |||
| handleEvent(event) { | |||
| const isListening = instance.isListening(); | |||
| const isKeyboardEventWithKey = event?.key !== void 0; | |||
There was a problem hiding this comment.
I can't find a reason why it's there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The PR fixes a bug where pressing a Ctrl/Cmd does not trigger a non-contiguous selection. The fix changes the behavior of how the state (pressed or not) of the modifiers' keys (Ctrl/Cmd, Shift, etc.) are observed. Previously, they were observed only when at least one of the Handsontable on the page was activated (by click or
setListeningmethod call). Now, they are observed once, globally, right after the table is initialized, whether the table is active or not.How has this been tested?
I tested the changes locally, and I covered the fix by update tests.
Types of changes
Related issue(s):
Affected project(s):
handsontableChecklist: