Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix editor incorrect width and height calculations #10504

Merged
merged 3 commits into from Sep 8, 2023

Conversation

budnix
Copy link
Member

@budnix budnix commented Sep 7, 2023

Context

The PR fixes a bug where the editor's max width and max height were incorrectly calculated. The bug appeared when the editor was opened on one of the overlays and the viewport was scrolled.

How has this been tested?

I tested the changes locally and covered the fix with new E2E tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Related issue(s):

  1. fixes https://github.com/handsontable/dev-handsontable/issues/96

Affected project(s):

  • handsontable

Checklist:

@budnix budnix self-assigned this Sep 7, 2023
@budnix budnix marked this pull request as ready for review September 7, 2023 13:12
@budnix budnix merged commit 532c83c into develop Sep 8, 2023
21 checks passed
@budnix budnix deleted the feature/dev-issue-96 branch September 8, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants