Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve accessibility of the dropdown menu. #10541

Merged
merged 7 commits into from Oct 24, 2023

Conversation

jansiegel
Copy link
Member

Context

This PR:

[skip changelog]

How has this been tested?

Modified the existing test case for Cmd/Ctrl+A to match the current requirements.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Additional language file or change to the existing one (translations)

Related issue(s):

  1. handsontable/dev-handsontable#1465

Affected project(s):

  • handsontable
  • @handsontable/angular
  • @handsontable/react
  • @handsontable/vue
  • @handsontable/vue3

Checklist:

- Exlude the dropdownMenu from reacting to ctrl/cmd + a
@jansiegel jansiegel requested a review from budnix October 18, 2023 10:54
Copy link
Member

@budnix budnix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm able to trigger the default Cmd+A action on a submenu
Kapture 2023-10-19 at 12 57 58

@jansiegel jansiegel requested a review from budnix October 24, 2023 07:21
Copy link
Member

@budnix budnix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Cmd+A keyboard shortcut should not work in the dropdown list of the Filter by condition component
Kapture 2023-10-24 at 10 02 38

Co-authored-by: Krzysztof Budnik <571316+budnix@users.noreply.github.com>
@jansiegel jansiegel requested a review from budnix October 24, 2023 08:40
@jansiegel jansiegel merged commit 2b17dc4 into feature/accessibility Oct 24, 2023
20 checks passed
@jansiegel jansiegel deleted the feature/dev-issue-1465 branch October 24, 2023 10:06
@budnix budnix mentioned this pull request Oct 24, 2023
4 tasks
@magierg
Copy link
Contributor

magierg commented Dec 1, 2023

Cmd/Ctrl+A works as expected on macOS & Windows in 14.0.0: https://jsfiddle.net/ezs4hgmn/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants