Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add key shortcuts and role attributes to the filtering menu's links. #10548

Merged
merged 2 commits into from Oct 24, 2023

Conversation

jansiegel
Copy link
Member

@jansiegel jansiegel commented Oct 24, 2023

Context

This PR:

  • Makes the Select All and Clear links react to both Enter and Space keys.
  • Adds role=button to those elements.

[skip changelog]

How has this been tested?

Added test cases.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Additional language file or change to the existing one (translations)

Related issue(s):

  1. handsontable/dev-handsontable#1485

Affected project(s):

  • handsontable
  • @handsontable/angular
  • @handsontable/react
  • @handsontable/vue
  • @handsontable/vue3

Checklist:

@jansiegel jansiegel requested a review from budnix October 24, 2023 08:37
@jansiegel jansiegel self-assigned this Oct 24, 2023
@jansiegel jansiegel merged commit 1610f41 into feature/accessibility Oct 24, 2023
19 of 21 checks passed
@jansiegel jansiegel deleted the feature/dev-issue-1485 branch October 24, 2023 09:07
@budnix budnix mentioned this pull request Oct 24, 2023
4 tasks
@AMBudnik
Copy link
Contributor

AMBudnik commented Dec 1, 2023

Works perfectly both SPACE and ENTER on those two buttons in 14.0.0 https://jsfiddle.net/mns5rjkz/15/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants