New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix accessibility issues in the docs #10574
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
table of contents
Launch the local version of documentation by running: npm run docs:review 5a5e238037fa6785dd9b3ee3d250581a5e2c24a5 |
budnix
previously approved these changes
Nov 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good 👌 I'll leave a small suggestion about correcting styles for the focus code tabs. Right now it looks like this:
diff --git a/docs/.vuepress/theme/styles/vuepress-tabs-custom.styl b/docs/.vuepress/theme/styles/vuepress-tabs-custom.styl
index c8a7d09ae..edf0638d5 100644
--- a/docs/.vuepress/theme/styles/vuepress-tabs-custom.styl
+++ b/docs/.vuepress/theme/styles/vuepress-tabs-custom.styl
@@ -35,6 +35,7 @@
a.tabs-component-tab-a {
padding: 0.5em 1.2em;
color: $textColor;
+ margin: 3px 3px 0px 3px;
&:hover {
text-decoration: none;
@@ -68,7 +69,7 @@
border-radius: 0;
}
}
-
+
&.selected-preview .tabs-component-panels {
background: transparent;
}
budnix
approved these changes
Nov 13, 2023
evanSe
added a commit
that referenced
this pull request
Nov 14, 2023
* fix(docs): tabIndex and ariaHidden permalink hash * fix(docs): image alt text in framework dropdown * fix(docs): focus style in navbar, sidebar, and table of contents * fix(docs): allow sidebar headings open keyboard * fix(docs): themeswitcher accessibility * add changelog * Add enter key press event to toggle theme switcher * fix height around home link * fix linting * fix lint * pr feedback * fix: patch package vue-tabs-component invalid aria
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We want to improve the accessibility of the Handsontable documentation.
How has this been tested?
Types of changes
Related issue(s):
Affected project(s):
docs
Checklist: