Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix editor's width miscalculations #10590

Merged
merged 6 commits into from
Nov 20, 2023
Merged

Fix editor's width miscalculations #10590

merged 6 commits into from
Nov 20, 2023

Conversation

budnix
Copy link
Member

@budnix budnix commented Nov 16, 2023

Context

The PR fixes an editor's textarea element miscalculations (jumping width) while typing that can be visible on low-end computers. To create a fix, the autoResize module had to be fixed. I simplified its code to listen only for one input event (it turned out to be enough), and I removed all workarounds from the text editor that unnecessarily calls the resize method. In the end, I decided to move the module to the general utils for better code owner feeling.

Before:

Kapture 2023-11-20 at 11 16 56

After:

Kapture 2023-11-20 at 11 17 51

How has this been tested?

I tested the changes locally with and without IME, and I covered the fix with updated tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Related issue(s):

  1. fixes https://github.com/handsontable/dev-handsontable/issues/1547

Affected project(s):

  • handsontable

Checklist:

@budnix budnix self-assigned this Nov 16, 2023
@budnix budnix marked this pull request as ready for review November 20, 2023 09:45
@budnix budnix merged commit 43b76b6 into develop Nov 20, 2023
20 of 21 checks passed
@budnix budnix deleted the feature/dev-issue-1547 branch November 20, 2023 11:12
jansiegel pushed a commit that referenced this pull request Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants