Fix editor's width miscalculations #10590
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The PR fixes an editor's textarea element miscalculations (jumping width) while typing that can be visible on low-end computers. To create a fix, the
autoResize
module had to be fixed. I simplified its code to listen only for oneinput
event (it turned out to be enough), and I removed all workarounds from the text editor that unnecessarily calls theresize
method. In the end, I decided to move the module to the general utils for better code owner feeling.Before:
After:
How has this been tested?
I tested the changes locally with and without IME, and I covered the fix with updated tests.
Types of changes
Related issue(s):
Affected project(s):
handsontable
Checklist: