New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the ability to disable column virtualization #10599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Launch the local version of documentation by running: npm run docs:review d230c64db1ebf8d79a71554fc958fbf53bcc53c9 |
budnix
changed the title
[wip] Add support for the ability to disable column virtualization
Add support for the ability to disable column virtualization
Nov 30, 2023
jansiegel
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The PR adds support for the ability to disable column virtualization throughout the new
renderAllColumns
option.In conjunction with the
renderAllRows
option, developers have the ability to disable virtualization for the whole table.Option combinations summary
Disables the column's virtualization only. This setup only makes sense when there is no vertical scroll (many columns and few rows). Due to the table nature where columns are related to rows (
TD
are children ofTR
), additional cell renders in all columns will be triggered when the vertical scroll changes, causing rows to re-render. The best setup forrenderAllColumns
is to disable the rows virtualization as well.In this case, the cells are rendered only once, no matter how big the dataset is. For both axes, there is a logged warning in the console that informs that there will be a performance drop if you disable the virtualization for 1000 or more records. And last one:
Disables virtualization for rows. The horizontal scroll does not affect the rows to re-render.
Other changes
ViewportColumnsCalculator
calculator by extracting the calculation of the stretching width to a separate module;How has this been tested?
I tested the changes locally and I covered the feature with new tests.
Types of changes
Related issue(s):
Affected project(s):
handsontable
Checklist: