Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable viewport scrolling on paste #10630

Merged
merged 7 commits into from Dec 7, 2023
Merged

Disable viewport scrolling on paste #10630

merged 7 commits into from Dec 7, 2023

Conversation

budnix
Copy link
Member

@budnix budnix commented Nov 30, 2023

Context

The PR fixes an issue related to the viewport scrolling issue after data pasting. As the issue points out, there should be no viewport move after paste.

How has this been tested?

I tested the changes locally, and I covered the fix with a test.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Related issue(s):

  1. fixes https://github.com/handsontable/dev-handsontable/issues/1458

Affected project(s):

  • handsontable

Checklist:

@budnix budnix self-assigned this Nov 30, 2023
@budnix budnix marked this pull request as ready for review November 30, 2023 14:10
Copy link

github-actions bot commented Nov 30, 2023

Launch the local version of documentation by running:

npm run docs:review 1666b049299c7a3178e06ca3784b0108d866151c

Copy link
Contributor

@wszymanski wszymanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@budnix budnix merged commit 9f64e16 into develop Dec 7, 2023
21 checks passed
@budnix budnix deleted the feature/dev-issue-1458 branch December 7, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants