New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a problem with keyboard navigation and scrolling on window-scrolled instances. #10655
Conversation
Note for the reviewer: |
*/ | ||
setBoundaries(boundaries) { | ||
setBoundaries(boundaries = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I ask to update the types as well? https://github.com/handsontable/handsontable/blob/feature/dev-issue-49/handsontable/types/plugins/dragToScroll/dragToScroll.d.ts#L12
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.. and then it'd be nice to create a test case for this plugin covering all TS things. Something like this https://github.com/handsontable/handsontable/blob/feature/issue-10515/handsontable/src/plugins/customBorders/__tests__/customBorders.types.ts
Launch the local version of documentation by running: npm run docs:review 9eec2888d369fdcc1d5a11b54f4ab14ec4879bc1 |
Context
The problem described in handsontable/dev-handsontable#49 is most probably caused by a fix made for #3070.
However, that fix seems to be no longer working (the drag-to-scroll feature for window-scrolled instances does not work currently).
This PR aims to:
How has this been tested?
Types of changes
Related issue(s):
Affected project(s):
handsontable
@handsontable/angular
@handsontable/react
@handsontable/vue
@handsontable/vue3
Checklist: