Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a problem with keyboard navigation and scrolling on window-scrolled instances. #10655

Merged
merged 5 commits into from Dec 27, 2023

Conversation

jansiegel
Copy link
Member

Context

The problem described in handsontable/dev-handsontable#49 is most probably caused by a fix made for #3070.
However, that fix seems to be no longer working (the drag-to-scroll feature for window-scrolled instances does not work currently).

This PR aims to:

How has this been tested?

  • Tested manually
  • Added test cases for element-scrolled instances

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Additional language file or change to the existing one (translations)

Related issue(s):

  1. handsontable/dev-handsontable#49
  2. Table scrolling bug when scrollable element is window #3070

Affected project(s):

  • handsontable
  • @handsontable/angular
  • @handsontable/react
  • @handsontable/vue
  • @handsontable/vue3

Checklist:

@jansiegel jansiegel self-assigned this Dec 12, 2023
@jansiegel jansiegel marked this pull request as ready for review December 12, 2023 16:02
@jansiegel
Copy link
Member Author

Note for the reviewer:
I couldn't figure out how to test drag-to-scroll on a window-scrolled instance (the problem is simulating mouse movement outside of the window), so I added just the tests for the element-scrolled ones. If you have any ideas on how to test those, I'll gladly add them.

budnix
budnix previously approved these changes Dec 14, 2023
*/
setBoundaries(boundaries) {
setBoundaries(boundaries = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@budnix budnix Dec 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.. and then it'd be nice to create a test case for this plugin covering all TS things. Something like this https://github.com/handsontable/handsontable/blob/feature/issue-10515/handsontable/src/plugins/customBorders/__tests__/customBorders.types.ts

Copy link

github-actions bot commented Dec 27, 2023

Launch the local version of documentation by running:

npm run docs:review 9eec2888d369fdcc1d5a11b54f4ab14ec4879bc1

@jansiegel jansiegel merged commit 34c74df into develop Dec 27, 2023
23 checks passed
@jansiegel jansiegel deleted the feature/dev-issue-49 branch December 27, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table scrolling bug when scrollable element is window
3 participants