Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve TS types of the Core related modules #10671

Merged
merged 3 commits into from Dec 19, 2023

Conversation

budnix
Copy link
Member

@budnix budnix commented Dec 18, 2023

Context

The PR improves TS types of the Core related modules.

  • Update JSDoc types to be more specific;
  • Narrow the types of the CellCoords class;
  • Rename col arguments to column;
  • Type Formulas plugin hooks with ExportedChange type instead of object;

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Affected project(s):

  • handsontable

Checklist:

@budnix budnix self-assigned this Dec 18, 2023
@budnix budnix marked this pull request as ready for review December 19, 2023 09:13
@budnix budnix merged commit 92e91fa into develop Dec 19, 2023
21 checks passed
@budnix budnix deleted the feature/improve-core-typings branch December 19, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants